-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.11] gh-98548: Fix -ne
shell operator spelling
#98556
Conversation
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting this!
Here is an example workflow run affected: https://github.com/python/cpython/actions/runs/3293756628/jobs/5430563962
That said, I'm not sure this is enough of a fix, because I think Github Actions runs with bash -e
. So I think we'd never get to this anyway? One option would be to use || (echo ... ; exit 1)
or something
Since the command expected to fail is short enough, maybe just if ! make check-abidump; then
echo ...
fi is sufficient? The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good to me. Want to update the 3.10 backport #98555 as well? :-) cc @JelleZijlstra
Updated #98555 too. |
Backport the workflow change and fix-ups: - pythonGH-92442 (e89c01e) - pythonGH-94129 (0dadb22) - pythonGH-98556 (194588d) Co-Authored-By: sterliakov <50529348+sterliakov@users.noreply.github.com>
Backport the workflow change and fix-ups: - GH-92442 (e89c01e) - GH-94129 (0dadb22) - GH-98556 (194588d) Co-Authored-By: sterliakov <50529348+sterliakov@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
gh-98548: Workflow not equal operator spelling
This shell operator should be spelled as -ne, not as -neq. All shell binary operators are two symbols long.
This bug is present on 3.10 and 3.11 branches only.
This follows #98555 for another affected branch.