We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_use_broken_old_ctypes_structure_semantics_
While working on #99283 I've noticed this piece of code:
cpython/Modules/_ctypes/stgdict.c
Lines 360 to 364 in 0124b5d
Lines 382 to 383 in 0124b5d
I've never seen this before, so I went and searched for this on the internet: https://cs.github.com/?scopeName=All+repos&scope=&q=_use_broken_old_ctypes_structure_semantics_
Looks like not a single GitHub project uses it.
Where is that used inside?
» ag _use_broken_old_ctypes_structure_semantics_ Tools/c-analyzer/cpython/globals-to-fix.tsv 761:Modules/_ctypes/stgdict.c PyCStructUnionType_update_stgdict PyId__use_broken_old_ctypes_structure_semantics_ - Include/internal/pycore_global_strings.h 253: STRUCT_FOR_ID(_use_broken_old_ctypes_structure_semantics_) Include/internal/pycore_runtime_init_generated.h 762: INIT_ID(_use_broken_old_ctypes_structure_semantics_), \ 1879: string = &_Py_ID(_use_broken_old_ctypes_structure_semantics_); 5734: if (Py_REFCNT((PyObject *)&_Py_ID(_use_broken_old_ctypes_structure_semantics_)) < _PyObject_IMMORTAL_REFCNT) { 5735: _PyObject_Dump((PyObject *)&_Py_ID(_use_broken_old_ctypes_structure_semantics_)); Modules/_ctypes/stgdict.c 383: &_Py_ID(_use_broken_old_ctypes_structure_semantics_), &tmp) < 0)
Basically in only one place (and generate code). No docs, no tests. No issues: https://github.com/python/cpython/issues?q=is%3Aissue+is%3Aopen+use_broken_old_ctypes_structure_semantics
And it feels like a python2 era thing. I think it is time to remove it.
PR is on its way, so we can discuss the changes in more details. CC @pitrou as the original author.
The text was updated successfully, but these errors were encountered:
pythongh-99284: [ctypes] remove `_use_broken_old_ctypes_structure_sem…
63d1574
…antics_`
gh-99284: [ctypes] remove `_use_broken_old_ctypes_structure_semantic…
a3360fa
…s_` (GH-99285) It was untested and undocumented. No code has been found in the wild that ever used it.
Fixed by a3360fa
Sorry, something went wrong.
No branches or pull requests
While working on #99283 I've noticed this piece of code:
cpython/Modules/_ctypes/stgdict.c
Lines 360 to 364 in 0124b5d
cpython/Modules/_ctypes/stgdict.c
Lines 382 to 383 in 0124b5d
I've never seen this before, so I went and searched for this on the internet: https://cs.github.com/?scopeName=All+repos&scope=&q=_use_broken_old_ctypes_structure_semantics_
Looks like not a single GitHub project uses it.
Where is that used inside?
Basically in only one place (and generate code).
No docs, no tests.
No issues: https://github.com/python/cpython/issues?q=is%3Aissue+is%3Aopen+use_broken_old_ctypes_structure_semantics
And it feels like a python2 era thing.
I think it is time to remove it.
PR is on its way, so we can discuss the changes in more details.
CC @pitrou as the original author.
_use_broken_old_ctypes_structure_semantics_
#99285The text was updated successfully, but these errors were encountered: