-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-99284: [ctypes] remove _use_broken_old_ctypes_structure_semantics_
#99285
Conversation
_use_broken_old_ctypes_structure_semantics_
_use_broken_old_ctypes_structure_semantics_
_use_broken_old_ctypes_structure_semantics_
I've messed up the issue number, sorry! |
Looks like this hack was added in ~2006. Some research of existing code to see if anything still relies on it is warranted before merging, it seems very unlikely. if so we'd want a deprecation period. |
Quoting the original issue:
I've done a minimal research. I was not able to find any references to it. I don't feel qualified in this specific module and its history to make an educated decision here. However, deprecation period is always a good idea 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please complete the doc.
This attribute was untested and undocumented. I never heard about it.
Looks like not a single GitHub project uses it.
I ran a code search in PyPI top 5000 projects: no projects use it.
$ ./search_pypi_top.py PYPI-2020-09-01/ '_use_broken_old_ctypes_structure_semantics_' -q
Found 0 matching lines in 0 projects
Misc/NEWS.d/next/Library/2022-11-09-12-36-12.gh-issue-99284.9p4J2l.rst
Outdated
Show resolved
Hide resolved
7f45ebc
to
1388dd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! FWIW I also searched our huge internal codebase at Google, nothing found that uses this odd thing.
_use_broken_old_ctypes_structure_semantics_
? #99284