Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust expression from == to != in alignment with the meaning of the paragraph. #104021

Merged
merged 2 commits into from
May 1, 2023
Merged

Adjust expression from == to != in alignment with the meaning of the paragraph. #104021

merged 2 commits into from
May 1, 2023

Conversation

faulhaberben
Copy link
Contributor

@faulhaberben faulhaberben commented Apr 30, 2023 •
edited by github-actions bot
Loading

More semantically clear expression.

📚 Documentation preview 📚: https://cpython-previews--104021.org.readthedocs.build/

@faulhaberben
Clarify venv.rst
4b0dcef 
More semantically clear expression.
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news awaiting review labels Apr 30, 2023
@Eclips4
Copy link
Member

Eclips4 commented Apr 30, 2023

Seems that you're right.

(venv) PS C:\Users\KIRILL-1\CLionProjects\cpython> python
Python 3.11.1 (tags/v3.11.1:a7a450f, Dec  6 2022, 19:58:39) [MSC v.1934 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import sys
>>> sys.prefix == sys.base_prefix
False

So, it's more convenient to put != here.

@arhadthedev arhadthedev changed the title gh-NNNNN: Adjust expression from == to != in alignment with the meaning of the paragraph. Adjust expression from == to != in alignment with the meaning of the paragraph. May 1, 2023
@vsajip vsajip merged commit 93107aa into python:main May 1, 2023
@vsajip vsajip added the needs backport to 3.11 only security fixes label May 1, 2023
@miss-islington
Copy link
Contributor

Thanks @faulhaberben for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-104031 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 1, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 1, 2023
@faulhaberben @miss-islington
Adjust expression from == to != in alignment with the meaning of …
3c1ba1d 
…the paragraph. (pythonGH-104021)

(cherry picked from commit 93107aa)

Co-authored-by: Ben Faulhaber <111227622+faulhaberben@users.noreply.github.com>
vsajip pushed a commit that referenced this pull request May 1, 2023
@miss-islington
[3.11] Adjust expression from == to != in alignment with the mean…
d8055b8 
…ing of the paragraph. (GH-104021) (GH-104031)

(cherry picked from commit 93107aa)
carljm added a commit to carljm/cpython that referenced this pull request May 1, 2023
@carljm
Merge branch 'main' into supermon
159b2aa 
* main: (26 commits)
  pythongh-104028: Reduce object creation while calling callback function from gc (pythongh-104030)
  pythongh-104036: Fix direct invocation of test_typing (python#104037)
  pythongh-102213: Optimize the performance of `__getattr__` (pythonGH-103761)
  pythongh-103895: Improve how invalid `Exception.__notes__` are displayed (python#103897)
  Adjust expression from `==` to `!=` in alignment with the meaning of the paragraph. (pythonGH-104021)
  pythongh-88496: Fix IDLE test hang on macOS (python#104025)
  Improve int test coverage (python#104024)
  pythongh-88773: Added teleport method to Turtle library (python#103974)
  pythongh-104015: Fix direct invocation of `test_dataclasses` (python#104017)
  pythongh-104012: Ensure test_calendar.CalendarTestCase.test_deprecation_warning consistently passes (python#104014)
  pythongh-103977: compile re expressions in platform.py only if required (python#103981)
  pythongh-98003: Inline call frames for CALL_FUNCTION_EX (pythonGH-98004)
  Replace Netlify with Read the Docs build previews (python#103843)
  Update name in acknowledgements and add mailmap (python#103696)
  pythongh-82054: allow test runner to split test_asyncio to execute in parallel by sharding. (python#103927)
  Remove non-existing tools from Sundry skiplist (python#103991)
  pythongh-103793: Defer formatting task name (python#103767)
  pythongh-87092: change assembler to use instruction sequence instead of CFG (python#103933)
  pythongh-103636: issue warning for deprecated calendar constants (python#103833)
  Various small fixes to dis docs (python#103923)
  ...
carljm added a commit to carljm/cpython that referenced this pull request May 1, 2023
@carljm
Merge branch 'main' into inlinecomp2
1274e2b 
* main: (463 commits)
  pythongh-104057: Fix direct invocation of test_super (python#104064)
  pythongh-87092: Expose assembler to unit tests (python#103988)
  pythongh-97696: asyncio eager tasks factory (python#102853)
  pythongh-84436: Immortalize in _PyStructSequence_InitBuiltinWithFlags() (pythongh-104054)
  pythongh-104057: Fix direct invocation of test_module (pythonGH-104059)
  pythongh-100458: Clarify Enum.__format__() change of mixed-in types in the whatsnew/3.11.rst (pythonGH-100387)
  pythongh-104018: disallow "z" format specifier in %-format of byte strings (pythonGH-104033)
  pythongh-104016: Fixed off by 1 error in f string tokenizer (python#104047)
  pythonGH-103629: Update Unpack's repr in compliance with PEP 692 (python#104048)
  pythongh-102799: replace sys.exc_info by sys.exception in inspect and traceback modules (python#104032)
  Fix typo in "expected" word in few source files (python#104034)
  pythongh-103824: fix use-after-free error in Parser/tokenizer.c (python#103993)
  pythongh-104035: Do not ignore user-defined `__{get,set}state__` in slotted frozen dataclasses (python#104041)
  pythongh-104028: Reduce object creation while calling callback function from gc (pythongh-104030)
  pythongh-104036: Fix direct invocation of test_typing (python#104037)
  pythongh-102213: Optimize the performance of `__getattr__` (pythonGH-103761)
  pythongh-103895: Improve how invalid `Exception.__notes__` are displayed (python#103897)
  Adjust expression from `==` to `!=` in alignment with the meaning of the paragraph. (pythonGH-104021)
  pythongh-88496: Fix IDLE test hang on macOS (python#104025)
  Improve int test coverage (python#104024)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eclips4 Eclips4 Eclips4 approved these changes

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@faulhaberben @Eclips4 @miss-islington @bedevere-bot @vsajip @arhadthedev