Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104057: Fix direct invocation of test_module #104059

Merged
merged 1 commit into from
May 1, 2023
Merged

gh-104057: Fix direct invocation of test_module #104059

merged 1 commit into from
May 1, 2023

Conversation

Eclips4
Copy link
Member

@Eclips4 Eclips4 commented May 1, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels May 1, 2023
@Eclips4
Copy link
Member Author

Eclips4 commented May 1, 2023

cc @AlexWaygood

@Eclips4 Eclips4 changed the title Fix direct invocation of test_module gh-104057: Fix direct invocation of test_module May 1, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 1, 2023
Closed
@zware zware added the skip news label May 1, 2023
@zware zware enabled auto-merge (squash) May 1, 2023 19:53
@Eclips4
Copy link
Member Author

Eclips4 commented May 1, 2023

Hello @zware!
Should it be backported to 3.11 branch?

@Eclips4
Copy link
Member Author

Eclips4 commented May 1, 2023

Also, I found an few similiar issues in tests.
Should I create an new issue for each of them?
I would create a one issue and just mention it in PR's.

@AlexWaygood AlexWaygood added the needs backport to 3.11 only security fixes label May 1, 2023
@AlexWaygood
Copy link
Member

Using one issue and linking multiple PRs to it would be best.

@Eclips4
Copy link
Member Author

Eclips4 commented May 1, 2023

Using one issue and linking multiple PRs to it would be best.

Thanks for your answer, Alex!
Should I create new issue, or just rename #104057 ?

@zware zware merged commit d448fcb into python:main May 1, 2023
@miss-islington
Copy link
Contributor

Thanks @Eclips4 for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @Eclips4 and @zware, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d448fcb0323bf00cb4ff4a1e65e8424a73b5f0d4 3.11

@zware
Copy link
Member

zware commented May 1, 2023

Using one issue and linking multiple PRs to it would be best.

Thanks for your answer, Alex! Should I create new issue, or just rename #104057 ?

I'll reopen and rename #104057.

@zware
Copy link
Member

zware commented May 1, 2023

Hello @zware! Should it be backported to 3.11 branch?

Apparently not :). That line doesn't exist in 3.11; if there's a similar issue in that branch, we should just create a clean PR against 3.11.

@zware zware removed the needs backport to 3.11 only security fixes label May 1, 2023
@AlexWaygood
Copy link
Member

Apparently not :). That line doesn't exist in 3.11

Oops, sorry 'bout that! I should have checked before adding the label.

@Eclips4 Eclips4 deleted the issue-104057 branch May 1, 2023 20:46
carljm added a commit to carljm/cpython that referenced this pull request May 1, 2023
@carljm
Merge branch 'main' into inlinecomp2
1274e2b 
* main: (463 commits)
  pythongh-104057: Fix direct invocation of test_super (python#104064)
  pythongh-87092: Expose assembler to unit tests (python#103988)
  pythongh-97696: asyncio eager tasks factory (python#102853)
  pythongh-84436: Immortalize in _PyStructSequence_InitBuiltinWithFlags() (pythongh-104054)
  pythongh-104057: Fix direct invocation of test_module (pythonGH-104059)
  pythongh-100458: Clarify Enum.__format__() change of mixed-in types in the whatsnew/3.11.rst (pythonGH-100387)
  pythongh-104018: disallow "z" format specifier in %-format of byte strings (pythonGH-104033)
  pythongh-104016: Fixed off by 1 error in f string tokenizer (python#104047)
  pythonGH-103629: Update Unpack's repr in compliance with PEP 692 (python#104048)
  pythongh-102799: replace sys.exc_info by sys.exception in inspect and traceback modules (python#104032)
  Fix typo in "expected" word in few source files (python#104034)
  pythongh-103824: fix use-after-free error in Parser/tokenizer.c (python#103993)
  pythongh-104035: Do not ignore user-defined `__{get,set}state__` in slotted frozen dataclasses (python#104041)
  pythongh-104028: Reduce object creation while calling callback function from gc (pythongh-104030)
  pythongh-104036: Fix direct invocation of test_typing (python#104037)
  pythongh-102213: Optimize the performance of `__getattr__` (pythonGH-103761)
  pythongh-103895: Improve how invalid `Exception.__notes__` are displayed (python#103897)
  Adjust expression from `==` to `!=` in alignment with the meaning of the paragraph. (pythonGH-104021)
  pythongh-88496: Fix IDLE test hang on macOS (python#104025)
  Improve int test coverage (python#104024)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zware zware zware approved these changes

Assignees

@zware zware

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some test modules fail when run as a script
5 participants
@Eclips4 @AlexWaygood @miss-islington @zware @bedevere-bot