Minor edits to the Descriptor HowTo Guide #24901

geryogam · 2021-03-17T10:31:27Z

This PR provides the following changes to the Descriptor HowTo Guide:

fix a typo;
fix a Sphinx tag preventing syntax highlighting;
fix a bug in ClassMethod;
reuse an existing cls name in Object;
allow keyword arguments in Type.__new__ and Object.__new__;
allow attribute lookup from a class in Member.__get__;
use two more super() in Object and Type for consistency.

…message for misspelled attributes (including __dict__)

…gth built-in types (int, tuple, bytes)

github-actions · 2021-06-05T00:18:12Z

This PR is stale because it has been open for 30 days with no activity.

merwok · 2022-02-11T13:26:38Z

Can you open a ticket (with Raymond Hettinger in nosy) to discuss the problems you have identified here?

geryogam · 2022-02-11T15:26:04Z

@merwok Thanks for the suggestion, that’s what I intended to do. The rest of the PR is completed but I still have to finish the last section on __slots__ (I completed my tests on it last year but I did not take the extra days necessary to update this PR). I will try to find a weekend shortly to do it.

Doc/howto/descriptor.rst

bedevere-bot · 2022-05-10T19:11:33Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

merwok · 2022-10-07T13:45:41Z

Please open a ticket to track this properly.

geryogam · 2022-10-07T17:43:42Z

Please open a ticket to track this properly.

Done: #98038

Doc/howto/descriptor.rst

miss-islington · 2022-10-09T01:54:24Z

Thanks @maggyero for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

bedevere-bot · 2022-10-09T01:54:32Z

GH-98112 is a backport of this pull request to the 3.11 branch.

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com> (cherry picked from commit 2d2e01a) Co-authored-by: Géry Ogam <gery.ogam@gmail.com>

miss-islington · 2022-10-09T02:02:11Z

Thanks @maggyero for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

bedevere-bot · 2022-10-09T02:02:18Z

GH-98114 is a backport of this pull request to the 3.10 branch.

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com> (cherry picked from commit 2d2e01a) Co-authored-by: Géry Ogam <gery.ogam@gmail.com>

* main: Minor edits to the Descriptor HowTo Guide (pythonGH-24901) Fix link to Lifecycle of a Pull Request in CONTRIBUTING (python#98102) pythonGH-94597: deprecate `SafeChildWatcher`, `FastChildWatcher` and `MultiLoopChildWatcher` child watchers (python#98089) Auto-cancel old builds when new commit pushed to branch (python#98009) pythongh-95011: Migrate syslog module to Argument Clinic (pythonGH-95012)

* main: (5519 commits) Minor edits to the Descriptor HowTo Guide (pythonGH-24901) Fix link to Lifecycle of a Pull Request in CONTRIBUTING (python#98102) pythonGH-94597: deprecate `SafeChildWatcher`, `FastChildWatcher` and `MultiLoopChildWatcher` child watchers (python#98089) Auto-cancel old builds when new commit pushed to branch (python#98009) pythongh-95011: Migrate syslog module to Argument Clinic (pythonGH-95012) pythongh-68686: Retire eptag ptag scripts (python#98064) pythongh-97922: Run the GC only on eval breaker (python#97920) GitHub Workflows security hardening (python#96492) Add `@ezio-melotti` as codeowner for `.github/`. (python#98079) pythongh-97913 Docs: Add walrus operator to the index (python#97921) [doc] Fix broken links to C extensions accelerating stdlib modules (python#96914) pythongh-97822: Fix http.server documentation reference to test() function (python#98027) pythongh-91052: Add PyDict_Unwatch for unwatching a dictionary (python#98055) pythonGH-98023: Change default child watcher to PidfdChildWatcher on supported systems (python#98024) pythonGH-94182: Run the PidfdChildWatcher on the running loop (python#94184) pythongh-92886: make test_ast pass with -O (assertions off) (pythonGH-98058) pythongh-92886: make test_coroutines pass with -O (assertions off) (pythonGH-98060) pythongh-57179: Add note on symlinks for os.walk (python#94799) pythongh-94808: Fix regex on exotic platforms (python#98036) pythongh-90085: Remove vestigial -t and -c timeit options (python#94941) ...

geryogam · 2022-10-09T12:49:30Z

Thanks for the review.

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com> (cherry picked from commit 2d2e01a) Co-authored-by: Géry Ogam <gery.ogam@gmail.com>

Fix wrong Sphinx markup preventing syntax highlighting

58b799d

the-knights-who-say-ni added the CLA signed label Mar 17, 2021

bedevere-bot added docs Documentation in the Doc dir awaiting review labels Mar 17, 2021

geryogam added 3 commits March 17, 2021 11:32

Fix a bug in the ClassMethod Python equivalent

f77b0f9

Fix the description of the ClassMethod Python equivalent

1dbd876

Raise TypeError for __get__(None, None) calls

d0d301e

geryogam changed the title ~~Fix a bug in the ClassMethod Python equivalent of the Descriptor HowTo Guide~~ Fix a few bugs in the Python equivalent code of the Descriptor HowTo Guide Mar 19, 2021

geryogam changed the title ~~Fix a few bugs in the Python equivalent code of the Descriptor HowTo Guide~~ Fix a few bugs in the Python equivalents of the Descriptor HowTo Guide Mar 19, 2021

geryogam added 4 commits March 22, 2021 16:43

Fix a typo

e87fe37

Use the existing cls variable

52a06d0

Allow keyword arguments in Object.__new__

2f9971b

Use two more super() for consistency

2f335ca

geryogam changed the title ~~Fix a few bugs in the Python equivalents of the Descriptor HowTo Guide~~ Fix the Python equivalents of the Descriptor HowTo Guide Mar 31, 2021

geryogam added 7 commits March 31, 2021 18:18

Add Object.__getattribute__ to raise AttributeError with the correct …

4886dbb

…message for misspelled attributes (including __dict__)

Allow attribute lookup from a class in Member.__get__

705c577

Allow keyword arguments in Type.__new__

c0e6432

Raise ValueError for slot names conflicting with class variables

81ec93c

Update descriptor.rst

34eef3a

Raise TypeError for non-empty __slots__ in subclasses of variable-len…

ae8c622

…gth built-in types (int, tuple, bytes)

Raise TypeError for non-empty __slots__ in subclasses of variable-len…

1d5fb96

…gth built-in types (int, tuple, bytes)

github-actions bot added the stale Stale PR or inactive for long period of time. label Jun 5, 2021

rhettinger reviewed May 10, 2022

View reviewed changes

Doc/howto/descriptor.rst Show resolved Hide resolved

rhettinger requested changes May 10, 2022

View reviewed changes

bedevere-bot removed the awaiting review label May 10, 2022

bedevere-bot added the awaiting changes label May 10, 2022

geryogam requested a review from rhettinger October 4, 2022 21:37

Merge branch 'main' into patch-14

c853e6b

geryogam mentioned this pull request Oct 7, 2022

Improve the Descriptor HowTo Guide #98038

Closed

rhettinger added skip issue skip news needs backport to 3.11 only security fixes labels Oct 7, 2022

rhettinger requested changes Oct 7, 2022

View reviewed changes

Doc/howto/descriptor.rst Outdated Show resolved Hide resolved

rhettinger changed the title ~~Improve the Descriptor HowTo Guide~~ Minor edits to the Descriptor HowTo Guide Oct 7, 2022

Update descriptor.rst

bcc9da0

rhettinger merged commit 2d2e01a into python:main Oct 9, 2022

bedevere-bot removed the awaiting changes label Oct 9, 2022

bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 9, 2022

rhettinger added the needs backport to 3.10 only security fixes label Oct 9, 2022

bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 9, 2022

rhettinger pushed a commit that referenced this pull request Oct 9, 2022

[3.10] Minor edits to the Descriptor HowTo Guide (GH-24901) (GH-98114)

820ef62

geryogam deleted the patch-14 branch October 10, 2022 21:53

mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022

Minor edits to the Descriptor HowTo Guide (pythonGH-24901)

cef2db9

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>

pablogsal pushed a commit that referenced this pull request Oct 22, 2022

Minor edits to the Descriptor HowTo Guide (GH-24901)

7460cf4

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com> (cherry picked from commit 2d2e01a) Co-authored-by: Géry Ogam <gery.ogam@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Minor edits to the Descriptor HowTo Guide #24901

Minor edits to the Descriptor HowTo Guide #24901

geryogam commented Mar 17, 2021 •

edited

Loading

github-actions bot commented Jun 5, 2021

merwok commented Feb 11, 2022

geryogam commented Feb 11, 2022

bedevere-bot commented May 10, 2022

merwok commented Oct 7, 2022

geryogam commented Oct 7, 2022

miss-islington commented Oct 9, 2022

bedevere-bot commented Oct 9, 2022

miss-islington commented Oct 9, 2022

bedevere-bot commented Oct 9, 2022

geryogam commented Oct 9, 2022

Minor edits to the Descriptor HowTo Guide #24901

Minor edits to the Descriptor HowTo Guide #24901

Conversation

geryogam commented Mar 17, 2021 • edited Loading

github-actions bot commented Jun 5, 2021

merwok commented Feb 11, 2022

geryogam commented Feb 11, 2022

bedevere-bot commented May 10, 2022

merwok commented Oct 7, 2022

geryogam commented Oct 7, 2022

miss-islington commented Oct 9, 2022

bedevere-bot commented Oct 9, 2022

miss-islington commented Oct 9, 2022

bedevere-bot commented Oct 9, 2022

geryogam commented Oct 9, 2022

geryogam commented Mar 17, 2021 •

edited

Loading