Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: fix broken links to modules #96914

Merged
merged 4 commits into from
Oct 8, 2022
Merged

DOC: fix broken links to modules #96914

merged 4 commits into from
Oct 8, 2022

Conversation

partev
Copy link
Contributor

@partev partev commented Sep 18, 2022

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Sep 18, 2022
@slateny
Copy link
Contributor

slateny commented Sep 19, 2022

By modules, I believe it refers to the C modules under Modules, not the Python ones under Lib. For example, the comments in _randommodule.c match up with what's listed in the license file.

@partev
Copy link
Contributor Author

partev commented Sep 19, 2022

By modules, I believe it refers to the C modules under Modules, not the Python ones under Lib. For example, the comments in _randommodule.c match up with what's listed in the license file.

sounds plausible. Should :mod: keyword be removed then?

@slateny
Copy link
Contributor

slateny commented Sep 20, 2022

Actually a correction - ctypes doesn't have a module under Lib so the change would make sense. As for keeping or changing _random/_decimal, I'm not too confident on that part but I feel that it should just be kept as it is now.

@CAM-Gerlach Could you double check my thoughts here?

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, You can prefix a reference name with ! to not resolve the reference, and just format the contents with the appropriate styling, i.e. :mod:`!_random` to mention the extension module, formatted as a module but without trying to resolve the reference, and you can also use a different display name as the actual resolved reference, i.e. `` :mod:_random <random> to specifically refer to the `_random` extension module while referring to the overall documentation for the `random` module.

However, given the evident confusion here over the ambiguity between a Python "module" and the C extension modules in the CPython Modules directory, and the need for clarity as far as licensing is concerned, I suggest specifically separating the two, as my GitHub suggestions illustrate, which link to the name/documentation for the overall module, but also make clear that the specific code the license refers to is the _-prefixed C extension module component.

I played around with several other words to describe the relationship other than "underlying", including "supporting", "for", "of", etc. and am not sure what people would like best here, but left it for now.

Doc/license.rst Outdated Show resolved Hide resolved
Doc/license.rst Outdated Show resolved Hide resolved
Doc/license.rst Outdated Show resolved Hide resolved
@CAM-Gerlach
Copy link
Member

CAM-Gerlach commented Sep 22, 2022

Actually a correction - ctypes doesn't have a module under Lib so the change would make sense. As for keeping or changing _random/_decimal, I'm not too confident on that part but I feel that it should just be kept as it is now.

Actually, it has a whole package under Lib.

@ambv ambv merged commit 840fd19 into python:main Oct 8, 2022
@partev partev deleted the patch-12 branch October 8, 2022 13:32
carljm added a commit to carljm/cpython that referenced this pull request Oct 8, 2022
* main:
  pythongh-68686: Retire eptag ptag scripts (python#98064)
  pythongh-97922: Run the GC only on eval breaker (python#97920)
  GitHub Workflows security hardening (python#96492)
  Add `@ezio-melotti` as codeowner for `.github/`. (python#98079)
  pythongh-97913 Docs: Add walrus operator to the index (python#97921)
  [doc] Fix broken links to C extensions accelerating stdlib modules (python#96914)
  pythongh-97822: Fix http.server documentation reference to test() function (python#98027)
  pythongh-91052: Add PyDict_Unwatch for unwatching a dictionary (python#98055)
  pythonGH-98023: Change default child watcher to PidfdChildWatcher on supported systems (python#98024)
  pythonGH-94182: Run the PidfdChildWatcher on the running loop (python#94184)
carljm added a commit to carljm/cpython that referenced this pull request Oct 9, 2022
* main: (5519 commits)
  Minor edits to the Descriptor HowTo Guide (pythonGH-24901)
  Fix link to Lifecycle of a Pull Request in CONTRIBUTING (python#98102)
  pythonGH-94597: deprecate `SafeChildWatcher`, `FastChildWatcher` and `MultiLoopChildWatcher` child watchers  (python#98089)
  Auto-cancel old builds when new commit pushed to branch (python#98009)
  pythongh-95011: Migrate syslog module to Argument Clinic (pythonGH-95012)
  pythongh-68686: Retire eptag ptag scripts (python#98064)
  pythongh-97922: Run the GC only on eval breaker (python#97920)
  GitHub Workflows security hardening (python#96492)
  Add `@ezio-melotti` as codeowner for `.github/`. (python#98079)
  pythongh-97913 Docs: Add walrus operator to the index (python#97921)
  [doc] Fix broken links to C extensions accelerating stdlib modules (python#96914)
  pythongh-97822: Fix http.server documentation reference to test() function (python#98027)
  pythongh-91052: Add PyDict_Unwatch for unwatching a dictionary (python#98055)
  pythonGH-98023: Change default child watcher to PidfdChildWatcher on supported systems (python#98024)
  pythonGH-94182: Run the PidfdChildWatcher on the running loop (python#94184)
  pythongh-92886: make test_ast pass with -O (assertions off) (pythonGH-98058)
  pythongh-92886: make test_coroutines pass with -O (assertions off) (pythonGH-98060)
  pythongh-57179: Add note on symlinks for os.walk (python#94799)
  pythongh-94808: Fix regex on exotic platforms (python#98036)
  pythongh-90085: Remove vestigial -t and -c timeit options (python#94941)
  ...
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
…ython#96914)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants