Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-27122: Fix comment to point to correct issue # #47

Merged
merged 1 commit into from
Feb 12, 2017

Conversation

njsmith
Copy link
Contributor

@njsmith njsmith commented Feb 12, 2017

It took me quite a bit to figure out what this was referring to, since the given issue number is wrong, and the original commit message I found through git blame lists a different, also wrong issue number... see https://bugs.python.org/issue27122#msg279449

Here's the correct issue link to confirm: https://bugs.python.org/issue27122

It took me quite a bit to figure out what this was referring to, since the given issue number is wrong, and the original commit message I found through git blame lists a different, also wrong issue number... see https://bugs.python.org/issue27122#msg279449
@codecov
Copy link

codecov bot commented Feb 12, 2017

Codecov Report

Merging #47 into master will decrease coverage by -0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage   82.37%   82.37%   -0.01%     
==========================================
  Files        1427     1427              
  Lines      350948   350948              
==========================================
- Hits       289089   289083       -6     
- Misses      61859    61865       +6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2294f3a...a4f3401. Read the comment docs.

@berkerpeksag berkerpeksag merged commit af88e7e into python:master Feb 12, 2017
berkerpeksag pushed a commit that referenced this pull request Feb 12, 2017
It took me quite a bit to figure out what this was referring to,
since the given issue number is wrong, and the original commit
message I found through git blame lists a different, also wrong
issue number... see https://bugs.python.org/issue27122#msg279449(cherry picked from commit af88e7e)
berkerpeksag pushed a commit that referenced this pull request Feb 12, 2017
It took me quite a bit to figure out what this was referring to,
since the given issue number is wrong, and the original commit
message I found through git blame lists a different, also wrong
issue number... see https://bugs.python.org/issue27122#msg279449

(cherry picked from commit af88e7e)
@berkerpeksag
Copy link
Member

Thanks! I've created #48 and #50 to backport this to maintenance branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants