Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport to 3.5] bpo-27122: Fix comment to point to correct issue number (#47) #50

Merged
merged 1 commit into from
Feb 12, 2017

Conversation

berkerpeksag
Copy link
Member

It took me quite a bit to figure out what this was referring to,
since the given issue number is wrong, and the original commit
message I found through git blame lists a different, also wrong
issue number... see https://bugs.python.org/issue27122#msg279449

(cherry picked from commit af88e7e)

It took me quite a bit to figure out what this was referring to,
since the given issue number is wrong, and the original commit
message I found through git blame lists a different, also wrong
issue number... see https://bugs.python.org/issue27122#msg279449

(cherry picked from commit af88e7e)
@codecov
Copy link

codecov bot commented Feb 12, 2017

Codecov Report

❗ No coverage uploaded for pull request base (3.5@9cd7e17). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             3.5      #50   +/-   ##
======================================
  Coverage       ?   82.37%           
======================================
  Files          ?     1427           
  Lines          ?   350948           
  Branches       ?        0           
======================================
  Hits           ?   289099           
  Misses         ?    61849           
  Partials       ?        0
Impacted Files Coverage Δ
Lib/_pydecimal.py 97.65% <ø> (ø)
Lib/asyncio/sslproto.py 78.61% <ø> (ø)
Lib/asyncio/futures.py 86.6% <ø> (ø)
Lib/code.py 67.21% <ø> (ø)
Lib/_bootlocale.py 50% <ø> (ø)
Lib/bisect.py 100% <ø> (ø)
Lib/calendar.py 85.41% <ø> (ø)
Lib/asyncio/test_utils.py 92.22% <ø> (ø)
Lib/bz2.py 97.05% <ø> (ø)
Lib/asyncio/windows_events.py 0.21% <ø> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cd7e17...df948fd. Read the comment docs.

@berkerpeksag berkerpeksag merged commit c6d2f49 into 3.5 Feb 12, 2017
@berkerpeksag berkerpeksag deleted the backport-3.5-pr-47 branch February 12, 2017 16:18
@berkerpeksag
Copy link
Member Author

Thanks for the approvals, Mariatta.

GitHub overwrote the original author's name again: c6d2f49

Mr3x33 added a commit to Mr3x33/cpython that referenced this pull request Sep 17, 2021
colesbury referenced this pull request in colesbury/nogil Oct 6, 2021
Once the threads object queue is empty, other threads may explicitly
merge reference counts immediately. It's no longer safe for the original
thread to do RC operations because of races with accesses to ob_ref_local.

This ensures that the queue is empty when it's removed from the hashtable
mapping thread-id to queue. There are still other RC operations that can
happen during thread destruction, so the call to _Py_queue_destroy will
probably need to be moved.

See #50
colesbury referenced this pull request in colesbury/nogil Oct 6, 2021
A partially initialized thread may have an entry in the interpreter
without a corresponding entry in the biased-refcounting hashtable.

See #50
jaraco pushed a commit that referenced this pull request Dec 2, 2022
Now reads: `The PR then needs to be backported manually.`
jaraco added a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
* Added a config for dependabot.

* Update features list for dependabot.

Co-authored-by: KOLANICH <kolan_n@mail.ru>
mgmacias95 pushed a commit to mgmacias95/cpython that referenced this pull request Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants