Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-92597: Ensure that AST nodes without explicit end positions can be compiled #93359

Merged
merged 3 commits into from
May 31, 2022
Merged

gh-92597: Ensure that AST nodes without explicit end positions can be compiled #93359

merged 3 commits into from
May 31, 2022

Conversation

pablogsal
Copy link
Member

Closes: #92597

@pablogsal pablogsal added the needs backport to 3.11 only security fixes label May 30, 2022
@pablogsal pablogsal force-pushed the gh-92597 branch 4 times, most recently from 47bf959 to 4fa8695 Compare May 30, 2022 19:01
@pablogsal pablogsal mentioned this pull request May 31, 2022
Closed
@nedbat
Copy link
Member

nedbat commented May 31, 2022

I can confirm that this fixes #93387.

@nedbat nedbat mentioned this pull request May 31, 2022
Closed
@pablogsal pablogsal merged commit 705eaec into python:main May 31, 2022
@pablogsal pablogsal deleted the gh-92597 branch May 31, 2022 23:00
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 31, 2022
@pablogsal @miss-islington
pythongh-92597: Ensure that AST nodes without explicit end positions …
a3156c6 
…can be compiled (pythonGH-93359)

(cherry picked from commit 705eaec)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-bot
Copy link

GH-93397 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 31, 2022
miss-islington added a commit that referenced this pull request May 31, 2022
@miss-islington @pablogsal
gh-92597: Ensure that AST nodes without explicit end positions can be…
b425d88 
… compiled (GH-93359)

(cherry picked from commit 705eaec)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@C4ptainCrunch C4ptainCrunch mentioned this pull request Jun 1, 2022
Open
9 tasks
@hugovk hugovk mentioned this pull request Jun 1, 2022
Merged
@davidhewitt davidhewitt mentioned this pull request Jun 1, 2022
Merged
LeMyst added a commit to LeMyst/WikibaseIntegrator that referenced this pull request Jun 1, 2022
@LeMyst
Disable pytest on 3.11-dev
549008e 
Solved in python/cpython#93359
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhadthedev arhadthedev arhadthedev left review comments

@isidentical isidentical Awaiting requested review from isidentical isidentical is a code owner

@markshannon markshannon Awaiting requested review from markshannon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash on AST with misordered linenos
5 participants
@pablogsal @nedbat @miss-islington @bedevere-bot @arhadthedev