-
-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-98741: Remove useless check_home usage from is_python_build usage (GH-98743) #98743
Merged
vsajip
merged 1 commit into
python:main
from
henryiii:henryiii/fix/is_python_build-check_home
Oct 26, 2022
Merged
gh-98741: Remove useless check_home usage from is_python_build usage (GH-98743) #98743
vsajip
merged 1 commit into
python:main
from
henryiii:henryiii/fix/is_python_build-check_home
Oct 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This argument does nothing but trigger a warning. Removed from internal usage. Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
vsajip
approved these changes
Oct 26, 2022
vsajip
changed the title
gh-98741: Remove useless check_home usage from is_python_build usage
gh-98741: Remove useless check_home usage from is_python_build usage (GH-98743)
Oct 26, 2022
Is there something that needs to be done to backport to 3.11.x? (As in, do I need to make a backport PR manually or is there some sort of bot command to do it?) |
There's an automatic way, I'll see to it - was waiting for the merge tests to complete. |
GH-98746 is a backport of this pull request to the 3.11 branch. |
Okay, just was making sure there wasn't something I needed to do. Thanks! |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 26, 2022
…usage (pythonGH-98743) (cherry picked from commit a508631) Co-authored-by: Henry Schreiner <HenrySchreinerIII@gmail.com>
vsajip
pushed a commit
that referenced
this pull request
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This argument does nothing but trigger a warning. Removed from internal usage.
Affects Python 3.11.0+.
See gh-98741.