-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.920 planning #11158
Comments
This is the release branch https://github.com/python/mypy/tree/release-0.920 |
#11168 needs to be CP'ed (done). |
❤️ I would like to see 6eafc5e included, which I think -- just judging by the dates -- should already be. I was surprised to find today, that there's no release already bringing the fix for |
That will be included! :-) The release branch is linked above / the cutoff date from master is Sept 20 |
It's well after Sept 20, but I'd love to see 9aaeef5 in the next release - |
@ilevkivskyi Will there be an official release candidate for 0.920 that I can test in my role as the Debian maintainer of https://packages.debian.org/sid/mypy or shall I make my own snapshot of https://github.com/python/mypy/tree/release-0.920 for testing? |
I made a snapshot of febec71 and I get this error
|
Thanks! I had packaged the latest release of tomli v1.2.1 in Debian, so that's probably why I had that problem https://tracker.debian.org/pkg/python-tomli ; I'll cherry-pick that PR into a local patch for my preparatory packaging of mypy 0.920 |
Also while I'm thinking about it we should probably mention #9275 being on the horizon in the 0.920 release notes. |
Thanks, that works! |
@Zac-HD Actually I tried cherry-picking but somehow I got a big merge conflict. I don't have much context, so not sure how to resolve, I think it would be better if you can make a CP PR against the 0.920 branch and I will merge it. |
Since there is a new pip, for upstream packagers we should probably also cherry-pick #11356 so that the tests aren't broken on rolling release distros. |
Yes, just cherry-picked that. |
#11531 (typed-ast bump) should go in for compatibility with tools that depend on typed-ast unconditionally, as typed-ast 1.4 breaks on newer Python 3.9 versions. |
We should cherry pick #11531 , since it'll allow users of Python 3.9 and 3.10 to check Python 2 code. More generally, is there anything I can do to help with the release? |
@hauntsaninja Double checking that all new features added since 0.910 are documented would be helpful, or just leaving a comment here if you find something that is not documented (clearly enough). Also, style and grammar checking documentation changes since 0.910 would be great. I'm planning to help with these, but I don't have the bandwidth to do this in the next several days at least. |
FWIW, I and @ilevkivskyi have some ideas about speeding up the release process. I hope to have the next release after 0.920 out within about a month of 0.920 being released. Also, we could document the steps we have for writing the release blog post and make it possible for everybody to help with that. |
#11532 should also help speed up the release process. Any help with this would be greatly appreciated! |
I recommend cherry picking the following docs updates: I recommend changing
(make this change directly, don't try to cherry pick from master) #11498 makes two small spelling fixes to docs (but the code changes don't apply cleanly to the release branch). |
Could we also cherry-pick #11632, which fixes a frequently reported crash? |
OK, cherry-picked this one and also #11630 |
Aside from double-checking documentation (#11158 (comment)), are there any more known release blockers? There doesn't seem to be any issue label such as "blocker" or "regression". |
I don't think that there are any remaining release blockers. We just need to finish the release process, and finish a release blog post. |
Maybe we should cherry-pick #11738 and update the trove classifiers to support Python 3.10? |
#11747 for trove classifiers |
#11729 means dropping python 3.6 support, should we update the mypy setup.py as well? |
#11729 does not imply mypy dropping Python 3.6 support, since it just changes the allowable upper bound with no change to lower bound. If you |
OK, great then! |
Cherry-picked also #11747, thanks @hauntsaninja! |
Cherry-picked #11749. |
I just uploaded https://pypi.org/project/mypy/0.920/ Could everyone please check if it works on their platforms? |
Works without issue type checking and mypyc compiling psf/black under Ubuntu 20.04.03 x86-64 CPython 3.8.5 :) |
A mypy upgrade for |
I'm not seeing any apparent crashes or installation failures on WSL or Windows.
|
Seems to be working well across platforms in a PR to typeshed; thanks for all the work to get this out! Btw, I noticed that the blog post is out, but http://mypy-lang.org/ doesn't yet show it |
I'm not sure if this is the right place to mention this, but I noticed a typo in the blog post. In the "Making a Variable Optional in an Else Block" section, "alllows" should be "allows". Out of curiosity, is there a github repo where I can look at the raw markdown and/or send a PR for the blog posts? |
Congratulations on the release; and thanks! For building mypy 0.920 on Debian, we are getting test errors that seem to be related to Python 3.10.1, even after applying #11752 ; are there other commits we should pull down? Full log of test errors is at https://gist.github.com/mr-c/80454ac454c1d69d57a093ff0e8bd53e |
That works, except for one test which I will probably skip manually; thanks!
|
Updated.
That's not public right how. I have plans to move the blog posts into a public repo at some point. |
A little update here: I just uploaded a minor bugfix release http://mypy-lang.blogspot.com/2021/12/mypy-0921-released.html I think this is issue can be closed now. Please feel free to re-open if there are some regressions that need to be released. |
I will be releasing mypy 0.920 soon. The release branch will be cut at a7d6e68. Please post here any PRs that need to be merged and cherry-picked.
The text was updated successfully, but these errors were encountered: