Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds docs about := and TypeGuard #11161

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Adds docs about := and TypeGuard #11161

merged 1 commit into from
Sep 21, 2021

Conversation

sobolevn
Copy link
Member

Closes #11075

JukkaL
JukkaL approved these changes Sep 21, 2021
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This isn't something that is super obvious for mypy users, so it's good to document it.

@JukkaL JukkaL merged commit 91f299e into python:master Sep 21, 2021
@sobolevn
Copy link
Member Author

:= still breaks my mind-python-parser 😆

Thanks for the merge!

@mcmasn-amzn
Copy link

Thank you for documenting this 😄

@hauntsaninja hauntsaninja mentioned this pull request Nov 12, 2021
Closed
ilevkivskyi pushed a commit that referenced this pull request Nov 16, 2021
@sobolevn
Adds docs about := and TypeGuard (#11161)
b1084ab 
Closes #11075
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: walrus TypeGuard
3 participants
@sobolevn @mcmasn-amzn @JukkaL