Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 2 virtualenv tests #10846

Closed
wants to merge 2 commits into from
Closed

Conversation

hauntsaninja
Copy link
Collaborator

Resolves #10407 as well as the mysteriously suddenly broken tests on
master.

hauntsaninja added 2 commits July 20, 2021 21:11
Resolves python#10407 as well as the mysteriously suddenly broken tests on
master.
@emmatyping
Copy link
Collaborator

Yeah I think there's another issue with Windows, I'll try to look at it tonight.

@hauntsaninja hauntsaninja marked this pull request as draft July 21, 2021 05:46
@hauntsaninja
Copy link
Collaborator Author

hauntsaninja commented Jul 21, 2021

The Windows failures look the same as the non-Windows failures to me... I was a little confused because tests passed locally, but tests on my laptop were getting skipped by

if (sys.platform == 'darwin' and hasattr(sys, 'base_prefix') and

A look would be welcome! It's not immediately obvious to me what's wrong / why it's picking up the stubs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Virtualenv pinned to <20
2 participants