Temporarily pin virtualenv to 16.7.10 to fix CI failures #10853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virtualenv 16.7.11 appears to have broken our CI by upgrading the version of pip embedded to something that doesn't support python 2, so this pins virtualenv to the last version that we know works.
emmatyping
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
virtualenv's 16.7.11 release yesterday appears to have broken our CI by updating the embedded version of pip to something that doesn't support python 2 (see #10407 (comment) for more info).
This is probably not an ideal long-term fix seeing as we're eventually going to need to switch to virtualenv 20 for python 3.10 support (see #10407), but this should fix CI long enough to find a better fix for this, whether that means:
Test Plan
I have no clue how to test this on my computer, but hopefully if the CI passes on this that should be enough confirmation that this works.