Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 600 supersedes PEP 513, PEP 571, PEP 599 #1960

Merged
merged 1 commit into from
Jun 26, 2021
Merged

PEP 600 supersedes PEP 513, PEP 571, PEP 599 #1960

merged 1 commit into from
Jun 26, 2021

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented May 13, 2021

Per PEP 600:

When this PEP is accepted, the previous manylinux PEPs will receive a final update noting that they are no longer maintained and referring to this PEP.

@mayeut mayeut requested review from njsmith, pfmoore and a team as code owners May 13, 2021 09:22
pradyunsg
pradyunsg approved these changes May 14, 2021
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got no power for the PEP processes, but... LGTM!

@mayeut mayeut marked this pull request as draft May 14, 2021 07:35
@mayeut
Copy link
Contributor Author

mayeut commented May 14, 2021

I forgot to put this one hold. #1962 needs to go in first.

@pfmoore
Copy link
Member

pfmoore commented May 14, 2021

,,, and #1962 is waiting on approval from the PEP 599 and PEP 600 authors (either on the PR itself, or in the Discourse thread raised for it)..

@mayeut
Copy link
Contributor Author

mayeut commented May 14, 2021 •
edited
Loading

c.f. Discourse thread for more details

@brettcannon
Copy link
Member

What's the status of this PR?

@pfmoore
Copy link
Member

pfmoore commented Jun 26, 2021

Waiting for @takluyver to approve #1962

I'm inclined to merge both PRs if @takluyver doesn't raise any objections in the next day or two.

@mayeut
PEP 600 supersedes PEP 513, PEP 571, PEP 599
f33be28 
Per PEP 600:
```
When this PEP is accepted, the previous manylinux PEPs will receive a final update noting that they are no longer maintained and referring to this PEP.
```
@pfmoore
Copy link
Member

pfmoore commented Jun 26, 2021

@mayeut if you take this PR out of draft mode and ping me, I'll merge it.

@mayeut mayeut marked this pull request as ready for review June 26, 2021 12:05
@mayeut
Copy link
Contributor Author

mayeut commented Jun 26, 2021

@pfmoore, rebased on master and marked ready for review.

@pfmoore
Copy link
Member

pfmoore commented Jun 26, 2021

Sigh. Looks like that triggered a couple more review requests via codeowners. I don't think I have the authority to override the requirement for those (I'm only the sponsor on this PEP).

@JelleZijlstra JelleZijlstra merged commit cd26ba8 into python:master Jun 26, 2021
@mayeut mayeut deleted the pep600-update branch June 26, 2021 16:33
@erlend-aasland erlend-aasland mentioned this pull request May 13, 2022
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

@pfmoore pfmoore pfmoore approved these changes

@takluyver takluyver takluyver approved these changes

@njsmith njsmith Awaiting requested review from njsmith

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mayeut @pfmoore @brettcannon @takluyver @pradyunsg @JelleZijlstra @the-knights-who-say-ni