Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 600: add manylinux2014 compatibility #1962

Merged
merged 1 commit into from
Jun 26, 2021
Merged

PEP 600: add manylinux2014 compatibility #1962

merged 1 commit into from
Jun 26, 2021

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented May 13, 2021

  • Add a link to PEP 599
  • Add a mention to manylinux2014 aliases

c.f. discussion for more details

@mayeut mayeut requested a review from njsmith as a code owner May 13, 2021 13:06
@mayeut
Copy link
Contributor Author

mayeut commented May 13, 2021

Not sure if/how the fact that an update was made should be reflected in the PEP given it's not Final/Active.

@mayeut mayeut changed the title PEP600: add manylinux2014 compatibility PEP 600: add manylinux2014 compatibility May 13, 2021
@mayeut
PEP600: add manylinux2014 compatibility
77c5fc2 
Add a link to PEP 599
Add a mention to manylinux2014 aliases
@mayeut mayeut force-pushed the pep600-manylinux2014 branch from 612565b to 77c5fc2 Compare May 13, 2021 13:20
@brettcannon brettcannon requested a review from pfmoore May 13, 2021 23:15
@mayeut mayeut mentioned this pull request May 14, 2021
Merged
@pfmoore
Copy link
Member

pfmoore commented May 14, 2021

I'm not going to be able to monitor this PR or the associated discussion. Please @-ping me explicitly when the three PEP authors have confirmed they are OK with this change.

@mayeut
Copy link
Contributor Author

mayeut commented May 22, 2021

@njsmith, @takluyver, @di,

gentle reminder: can you review this per Paul's comment. Thanks

@mayeut
Copy link
Contributor Author

mayeut commented Jun 4, 2021

@njsmith, @takluyver,

gentle reminder: can you review this per Paul's comment. Thanks

takluyver
takluyver reviewed Jun 26, 2021
View reviewed changes
Copy link
Contributor

@takluyver takluyver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry for the delay!

I think @mayeut is currently much more involved with the manylinux machinery and definitions than I am. Perhaps PEPs, like packages, should have 'authors' and 'maintainers'. 🙂

takluyver
takluyver approved these changes Jun 26, 2021
View reviewed changes
Copy link
Contributor

@takluyver takluyver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(And now I got the wrong radio button...)

@pfmoore pfmoore merged commit 9c51901 into python:master Jun 26, 2021
@pfmoore
Copy link
Member

pfmoore commented Jun 26, 2021

Thanks @takluyver! Normally PEPs don't get substantive updates after they are published, so this isn't typically a big deal. It would probably be useful to move the specification out of the PEPs, and into https://packaging.python.org/specifications/platform-compatibility-tags/. That would also mean maintenance could be handled outside of the PEP repo.

@mayeut mayeut deleted the pep600-manylinux2014 branch June 26, 2021 12:03
@erlend-aasland erlend-aasland mentioned this pull request May 13, 2022
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfmoore pfmoore pfmoore approved these changes

@njsmith njsmith njsmith approved these changes

@takluyver takluyver takluyver approved these changes

@di di di approved these changes

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mayeut @pfmoore @di @takluyver @njsmith @the-knights-who-say-ni