Change to -stubs over _stubs #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also note that a py.typed file is not needed for stub only packages.
|
Yup! |
|
Great! I will update the implementation later today. |
alanhdu
added a commit
to alanhdu/numpy-stubs
that referenced
this pull request
Feb 18, 2018
alanhdu
added a commit
to alanhdu/numpy-stubs
that referenced
this pull request
Feb 18, 2018
shoyer
pushed a commit
to numpy/numpy-stubs
that referenced
this pull request
Feb 18, 2018
* Replace tab in setup.py with spaces * Add Travis * Add flake8 config to pass tests * Use `-` instead of `_` See python/peps#568 * Add Travis badge to README * Use numpy 1.14.0
alanhdu
pushed a commit
to alanhdu/numpy-stubs
that referenced
this pull request
Feb 18, 2018
* Replace tab in setup.py with spaces * Add Travis * Add flake8 config to pass tests * Use `-` instead of `_` See python/peps#568 * Add Travis badge to README * Use numpy 1.14.0
shoyer
pushed a commit
to numpy/numpy-stubs
that referenced
this pull request
Feb 19, 2018
* Add some typehints * Add ctypes typehints * Add stubs for dtype * Setup Travis and correct setup.py (#8) * Replace tab in setup.py with spaces * Add Travis * Add flake8 config to pass tests * Use `-` instead of `_` See python/peps#568 * Add Travis badge to README * Use numpy 1.14.0 * Fix some type annotations * Make attributes read-only properties * Add metadata property * Move flags into flagobj * Add _Shape type alias * Alphabetize properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also note that a py.typed file is not needed for stub only packages.
cc @gvanrossum I believe you wanted these changes based on last Friday's discussion?