Register torch.linalg.LinAlgError to pyro exception handling #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This includes two major changes of interest to botorch: 1. Support for pytorch 2.0 (allowing us to not require pyro dev branch when testing against pytorch nightlies): pyro-ppl/pyro#3164 2. The ability to registering of custom exception handlers for numerical issues: pyro-ppl/pyro#3168 Pull Request resolved: pytorch#1606 Reviewed By: saitcakmak Differential Revision: D42330914 Pulled By: Balandat fbshipit-source-id: 440d9ff00df60f4ba88acc82e323f9e675caf254
Summary: Uses draft changes from pyro-ppl/pyro#3168 (part of pyro 1.8.4 pulled in via D42331876) to register handling of `torch.linalg.LinAlgError` and the `ValueError` that can be raised in the torch distribution's `__init__()` Differential Revision: D42159791 fbshipit-source-id: ef1f53c9471ba8b1d62ca5ad347e5a471d9bb7a1
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D42159791 |
Codecov Report
@@ Coverage Diff @@
## main #1607 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 154 154
Lines 13775 13768 -7
=========================================
- Hits 13775 13768 -7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This pull request has been merged in cbbbf11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Uses draft changes from pyro-ppl/pyro#3168 (part of pyro 1.8.4 pulled in via D42331876) to register handling of
torch.linalg.LinAlgErrorand theValueErrorthat can be raised in the torch distribution's__init__()Differential Revision: D42159791