Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register torch.linalg.LinAlgError to pyro exception handling #1607

Closed
wants to merge 2 commits into from
Closed

Register torch.linalg.LinAlgError to pyro exception handling #1607

wants to merge 2 commits into from

Commits on Jan 4, 2023

  1. Bump pyro-ppl requirement to >=1.8.4 (pytorch#1606) 

    Summary:
This includes two major changes of interest to botorch:
1. Support for pytorch 2.0 (allowing us to not require pyro dev branch when testing against pytorch nightlies): pyro-ppl/pyro#3164
2. The ability to registering of custom exception handlers for numerical issues: pyro-ppl/pyro#3168

Pull Request resolved: pytorch#1606

Reviewed By: saitcakmak

Differential Revision: D42330914

Pulled By: Balandat

fbshipit-source-id: 440d9ff00df60f4ba88acc82e323f9e675caf254
    @Balandat @facebook-github-bot
    Balandat authored and facebook-github-bot committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    5b7ce12 View commit details
    Browse the repository at this point in the history

  2. Register torch.linalg.LinAlgError to pyro exception handling 

    Summary: Uses draft changes from pyro-ppl/pyro#3168 (part of pyro 1.8.4 pulled in via D42331876) to register handling of `torch.linalg.LinAlgError` and the `ValueError` that can be raised in the torch distribution's `__init__()`

Differential Revision: D42159791

fbshipit-source-id: ef1f53c9471ba8b1d62ca5ad347e5a471d9bb7a1
    @Balandat @facebook-github-bot
    Balandat authored and facebook-github-bot committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    35df664 View commit details
    Browse the repository at this point in the history