-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arm Backend: Generate input if not supplied in the non semihosting #5308
Arm Backend: Generate input if not supplied in the non semihosting #5308
Conversation
…st setup Signed-off-by: Zingo Andersen <zingo.andersen@arm.com> Change-Id: I6ca9c41b0dd3a5bc44fc33431951ae58259842be
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5308
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 40 PendingAs of commit 2a6f91d with merge base fcbbef4 (): NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot label ciflow/trunk |
sorry I don't see a fill, all I see is a check |
In the normal case (non semihosting) the check always fails right now, as we don't have any input so the function exits too early by mistake. This check was added when we added the semihosting mode for the FVP to detect if the input file is wrong/missing. E.g. original this function created example input and filled it with 1 (that should be later in the function) but when we added semihosting we missed that we didn't run this code for non semihosting at all. |
…pplied-in-the-non-semihosting-test-setup
I think I get it. In Semihosting mode you don't want to fill 1's for some reason, right? |
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
in semihosting there are files placed with smoketest input/output data so we can compare some more useful tensor input. |
@digantdesai merged this pull request in 9c5994d. |
This will generate fake input filled with 1 instead of no input if no input is supplied.