Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arm Backend: Generate input if not supplied in the non semihosting #5308

Conversation

zingo
Copy link
Collaborator

@zingo zingo commented Sep 12, 2024

This will generate fake input filled with 1 instead of no input if no input is supplied.

…st setup

Signed-off-by: Zingo Andersen <zingo.andersen@arm.com>
Change-Id: I6ca9c41b0dd3a5bc44fc33431951ae58259842be
Copy link

pytorch-bot bot commented Sep 12, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5308

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 40 Pending

As of commit 2a6f91d with merge base fcbbef4 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 12, 2024
@zingo zingo added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Sep 12, 2024
@zingo
Copy link
Collaborator Author

zingo commented Sep 12, 2024

@pytorchbot label ciflow/trunk

@digantdesai
Copy link
Contributor

sorry I don't see a fill, all I see is a check

@zingo
Copy link
Collaborator Author

zingo commented Sep 12, 2024

In the normal case (non semihosting) the check always fails right now, as we don't have any input so the function exits too early by mistake. This check was added when we added the semihosting mode for the FVP to detect if the input file is wrong/missing. E.g. original this function created example input and filled it with 1 (that should be later in the function) but when we added semihosting we missed that we didn't run this code for non semihosting at all.

@digantdesai
Copy link
Contributor

I think I get it. In Semihosting mode you don't want to fill 1's for some reason, right?

@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@robell
Copy link
Collaborator

robell commented Sep 13, 2024

in semihosting there are files placed with smoketest input/output data so we can compare some more useful tensor input.
This assert was buggy for non-semihosting (run.sh flows) where it early exited the function so we wouldn't get 1's in the tensor, and so e.g. the delegated add would just report 0's instead of 2's.

@facebook-github-bot
Copy link
Contributor

@digantdesai merged this pull request in 9c5994d.

lucylq pushed a commit that referenced this pull request Sep 17, 2024
…5308)

Summary:
This will generate fake input filled with 1 instead of no input if no input is supplied.

Pull Request resolved: #5308

Reviewed By: swolchok

Differential Revision: D62645530

Pulled By: digantdesai

fbshipit-source-id: fdb313dfee3413f87884ab6416af18e1ecf77a39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants