Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Ethos-U85 support to Arm aot_arm_compiler #5345

Closed
wants to merge 6 commits into from

Conversation

robell
Copy link
Collaborator

@robell robell commented Sep 13, 2024

Some changes to enable using the new compiler flow and backend for both Ethos-U55 and Ethos-U85.

This change means the run.sh flow uses the new compiler for Ethos-U55.

It enables Ethos-U85 to be targeted for compilation, but this feature isn't used in run.sh yet.

Copy link

pytorch-bot bot commented Sep 13, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5345

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9abc537 with merge base df72b8c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 13, 2024
@robell
Copy link
Collaborator Author

robell commented Sep 13, 2024

@digantdesai can we push PR #5308, then i'll rebase and remove my commit which does much the same.
and btw, the lintrunner fix isn't needed as that's the patch which will be reverted.

@robell robell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Sep 13, 2024
Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks.

examples/arm/aot_arm_compiler.py Show resolved Hide resolved
examples/arm/aot_arm_compiler.py Outdated Show resolved Hide resolved
@digantdesai
Copy link
Contributor

@digantdesai can we push PR #5308, then i'll rebase and remove my commit which does much the same. and btw, the lintrunner fix isn't needed as that's the patch which will be reverted.

I will merge #5308 ASAP and then you can rebase.

@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@digantdesai
Copy link
Contributor

Seems like U55 tests are failing.

- Support for nn.modules in a seperate file
- Ability to select target IP for the ArmBackend
- Option to dump intermediate outputs for debug.

Signed-off-by: Rob Elliott <robert.elliott@arm.com>
Change-Id: I40cef76da593bd6f06bab067d3f0fc1ae31adc44
With Ethos-U85 being enabled in the main ArmBackend and compile spec, this change
enables it from the command line for compilation in preperation for run.sh support
in newer examples.

Signed-off-by: Rob Elliott <robert.elliott@arm.com>
Change-Id: I33e44f000fb24bc70b468fbffbf547e9775a1132
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Copy link
Collaborator Author

robell commented Sep 24, 2024

@digantdesai that failure was a side-effect of the pin move so was resolved now this is rebased on top of #5346 unit test fixes . looks like all but meta internal-only has returned a result.

@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@digantdesai
Copy link
Contributor

Let me try to merge this ASAP

@facebook-github-bot
Copy link
Contributor

@digantdesai merged this pull request in 8660faf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants