Properly kill the buck2 daemon

[dbort]

Fix the buck2 kill command. Because of scoping issues, in some cases we only ran " kill" because the local value of $BUCK2 was empty.

This should help avoid failures like

  Error validating working directory
  Caused by:
      0: Failed to stat `/home/ubuntu/cmodi/executorch/buck-out/v2`
      1: ENOENT: No such file or directory

which are typically fixed by running buck2 kill.

Add "COMMAND_ECHO" to the kill command to show what we're running.

Also, make the function consistently use executorch_root as the working directory. We should always run buck2 from the ET repo.

Test Plan:

rm -rf buck-out
(rm -rf cmake-out \
    && mkdir cmake-out \
    && cd cmake-out \
    && cmake ..)

Output showed that the local variable works:

-- Resolved buck2 as /Users/***/local/executorch/cmake-out/buck2-bin/buck2-99773fe6f7963a72ae5f7b737c02836e.
-- Killing buck2 daemon
'/Users/***/local/executorch/cmake-out/buck2-bin/buck2-99773fe6f7963a72ae5f7b737c02836e kill'

And that the parent variable still works:

-- ******** Summary ********
...
--   BUCK2                         : /Users/***/local/executorch/cmake-out/buck2-bin/buck2-99773fe6f7963a72ae5f7b737c02836e

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5863

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7257958 with merge base eecf74f ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[dbort]

Manual cherry-pick of #5373 from 70aee72. pytorchbot didn't work on it.

[dvorjackz]

This is very helpful 🙏🏻