Commits on Oct 4, 2024

1. Properly kill the buck2 daemon …

   Summary:
   Fix the `buck2 kill` command. Because of scoping issues, in some cases we only ran "` kill`" because the local value of `$BUCK2` was empty.
   
   This should help avoid failures like
   
   ```
     Error validating working directory
     Caused by:
         0: Failed to stat `/home/ubuntu/cmodi/executorch/buck-out/v2`
         1: ENOENT: No such file or directory
   ```
   
   which are typically fixed by running `buck2 kill`.
   
   Add "COMMAND_ECHO" to the kill command to show what we're running.
   
   Also, make the function consistently use `executorch_root` as the working directory. We should always run buck2 from the ET repo.
   
   Reviewed By: byjlw
   
   Differential Revision: D62676219
   
   fbshipit-source-id: 28f032a05d2c66dc21b30c783617eb1a77e28e64

   

   dbort committed Oct 4, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 7257958
   • Browse repository at this point

   Copy the full SHA

   7257958 View commit details

   Browse the repository at this point in the history