Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pybind] Find portable_lib.so in pip package during cmake build #6141

Open
wants to merge 1 commit into
base: release/0.4
Choose a base branch
from

Conversation

pytorchbot
Copy link
Collaborator

  • Rename _portable_lib.cpython-3.<distribution info>.so to _portable_lib.so so it can be found by CMake find_library(). This can be achieved by setting SETUPTOOLS_EXT_SUFFIX.
  • Since executorch-config.cmake is also being used to find installed libraries such as executorch.a, xnnpack_backend.a, add a condition to tell if executorch-config.cmake is being used in cmake-out or site-packages.

Summary:
* Rename `_portable_lib.cpython-3.<distribution info>.so` to `_portable_lib.so` so it can be found by CMake `find_library()`. This can be achieved by setting `SETUPTOOLS_EXT_SUFFIX`.
* Since `executorch-config.cmake` is also being used to find installed libraries such as `executorch.a`, `xnnpack_backend.a`, add a condition to tell if `executorch-config.cmake` is being used in cmake-out or site-packages.

Pull Request resolved: #5961

Reviewed By: metascroy

Differential Revision: D64014291

Pulled By: larryliu0820

fbshipit-source-id: 2757f2883d3f836e9efd45676f792c12f742e63d
(cherry picked from commit 7337f8e)
Copy link

pytorch-bot bot commented Oct 10, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6141

Note: Links to docs will display an error until the docs builds have been completed.

❌ 14 New Failures, 2 Unrelated Failures

As of commit f556445 with merge base eecf74f (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants