Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pybind] Find portable_lib.so in pip package during cmake build #6141

Open
wants to merge 1 commit into
base: release/0.4
Choose a base branch
from
Open

[pybind] Find portable_lib.so in pip package during cmake build #6141

wants to merge 1 commit into from
+117 −67

Commits on Oct 10, 2024

  1. Find portable_lib.so in pip package during cmake build (#5961) 

    Summary:
* Rename `_portable_lib.cpython-3.<distribution info>.so` to `_portable_lib.so` so it can be found by CMake `find_library()`. This can be achieved by setting `SETUPTOOLS_EXT_SUFFIX`.
* Since `executorch-config.cmake` is also being used to find installed libraries such as `executorch.a`, `xnnpack_backend.a`, add a condition to tell if `executorch-config.cmake` is being used in cmake-out or site-packages.

Pull Request resolved: #5961

Reviewed By: metascroy

Differential Revision: D64014291

Pulled By: larryliu0820

fbshipit-source-id: 2757f2883d3f836e9efd45676f792c12f742e63d
(cherry picked from commit 7337f8e)
    @larryliu0820 @pytorchbot
    larryliu0820 authored and pytorchbot committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    f556445 View commit details
    Browse the repository at this point in the history