cov: add tests for ignite.metrics #1816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydcjeff
commented
Mar 18, 2021
| @@ -478,16 +478,6 @@ def __mod__(self, other: Any) -> "MetricsLambda": | |||
|
|
|||
| return MetricsLambda(lambda x, y: x % y, self, other) | |||
|
|
|||
| def __div__(self, other: Any) -> "MetricsLambda": | |||
There was a problem hiding this comment.
These are only applicable to py2 : test
ydcjeff
commented
Mar 18, 2021
Comment on lines
-188
to
-189
| else: | ||
| raise ValueError(f"multiref : wrong value (got : {self._multiref})") |
There was a problem hiding this comment.
This is no need to catch. The same error has been caught above.
|
@ydcjeff, just a small though on saving computational resources while merging master to all PRs. When PR is approved we can update it once and then merge and avoid updating all PRs. |
vfdev-5
reviewed
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1790
Description: Add tests / Removed unused code for ignite.metrics
Check list: