-
-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve code coverage #1790
Comments
That sounds like a group effort. shall we update the task with a checkbox list of packages so that we make sure that no two people will be working on the same package? I can start with |
@vfdev-5 Can I work on ignite/engine/engine.py? |
@soma2000-lang sure. Do you know how to tackle this issue ? |
@vfdev I will try
…On Tue, 18 Oct 2022 at 01:01, vfdev ***@***.***> wrote:
@soma2000-lang <https://github.com/soma2000-lang> sure. Do you know how
to tackle this issue ?
Basically, you can check uncovered lines from
https://app.codecov.io/gh/pytorch/ignite/blob/master/ignite/engine/engine.py
and write tests in
https://github.com/pytorch/ignite/blob/master/tests/ignite/engine/test_engine.py
to fix the coverage.
—
Reply to this email directly, view it on GitHub
<#1790 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANLS36MHERWU4SGGVDX6MPDWDWSR7ANCNFSM4ZFDCPJQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@vfdev-5 https://app.codecov.io/gh/pytorch/ignite/blob/master/ignite/engine/engine.py in this file I see almost everything is covered .Please correct me if I am wrong |
@soma2000-lang yes 97% of the code is covered but we need to cover up to 100% if possible. |
Ok
…On Mon, 24 Oct 2022, 13:08 vfdev, ***@***.***> wrote:
@soma2000-lang <https://github.com/soma2000-lang> yes 97% of the code is
covered but we need to cover up to 100% if possible.
—
Reply to this email directly, view it on GitHub
<#1790 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANLS36ND6UIJ47H7AZODIHLWEY4IZANCNFSM4ZFDCPJQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Our project code coverage start to decrease with new features and reworked tests. We are now ~95% but were 96% recently and around ~98% the last year...
The idea is to identify the uncovered parts of code inspecting here, for example: https://codecov.io/gh/pytorch/ignite/tree/master/ignite and draft a PR with new tests.
Some of new test can be very simple and others could be very sophisticated to enter a particular code line.
Let's improve the coverage of all modules, except
distributed
for instance.ignite.base
ignite.contrib.engines
ignite.contrib.handlers
ignite.contrib.metrics
ignite/engine/__init__.py
ignite/engine/engine.py
ignite/engine/events.py
ignite/handlers/checkpoint.py
ignite.metrics
The text was updated successfully, but these errors were encountered: