Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code coverage #1790

Open
8 of 9 tasks
vfdev-5 opened this issue Mar 14, 2021 · 7 comments
Open
8 of 9 tasks

Improve code coverage #1790

vfdev-5 opened this issue Mar 14, 2021 · 7 comments

Comments

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Mar 14, 2021

Our project code coverage start to decrease with new features and reworked tests. We are now ~95% but were 96% recently and around ~98% the last year...

The idea is to identify the uncovered parts of code inspecting here, for example: https://codecov.io/gh/pytorch/ignite/tree/master/ignite and draft a PR with new tests.

Some of new test can be very simple and others could be very sophisticated to enter a particular code line.
Let's improve the coverage of all modules, except distributed for instance.

  • ignite.base
  • ignite.contrib.engines
  • ignite.contrib.handlers
  • ignite.contrib.metrics
  • ignite/engine/__init__.py
  • ignite/engine/engine.py
  • ignite/engine/events.py
  • ignite/handlers/checkpoint.py
  • ignite.metrics
@Moh-Yakoub
Copy link
Contributor

Moh-Yakoub commented Mar 14, 2021

That sounds like a group effort. shall we update the task with a checkbox list of packages so that we make sure that no two people will be working on the same package?

I can start with engine/__init__.py

@soma2000-lang
Copy link
Contributor

@vfdev-5 Can I work on ignite/engine/engine.py?

@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Oct 17, 2022

@soma2000-lang sure. Do you know how to tackle this issue ?
Basically, you can check uncovered lines from https://app.codecov.io/gh/pytorch/ignite/blob/master/ignite/engine/engine.py and write tests in https://github.com/pytorch/ignite/blob/master/tests/ignite/engine/test_engine.py to fix the coverage.

@soma2000-lang
Copy link
Contributor

soma2000-lang commented Oct 17, 2022 via email

@soma2000-lang
Copy link
Contributor

@vfdev-5 https://app.codecov.io/gh/pytorch/ignite/blob/master/ignite/engine/engine.py in this file I see almost everything is covered .Please correct me if I am wrong

@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Oct 24, 2022

@soma2000-lang yes 97% of the code is covered but we need to cover up to 100% if possible.

@soma2000-lang
Copy link
Contributor

soma2000-lang commented Oct 24, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants