Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST Increases test coverage for checkpoint #1957

Merged
merged 3 commits into from
Apr 22, 2021
Merged

TST Increases test coverage for checkpoint #1957

merged 3 commits into from
Apr 22, 2021

Conversation

thomasjpfan
Copy link
Contributor

@thomasjpfan thomasjpfan commented Apr 22, 2021 •
edited
Loading

Addresses a part of #1790

Description:

Increases the test coverage for ignite/handlers/checkpoint.py.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: handlers Core Handlers module label Apr 22, 2021
vfdev-5
vfdev-5 approved these changes Apr 22, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thomasjpfan Thanks for the contribution, Thomas !
LGTM!

@vfdev-5 vfdev-5 merged commit 6969ffe into pytorch:master Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
module: handlers Core Handlers module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasjpfan @vfdev-5