Remove DataID attribute access #2396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a key attribute access is absent for a dataid, raise the correct type of AttributeError. Fixes pytroll#2395.
Codecov Report
@@ Coverage Diff @@
## main #2396 +/- ##
==========================================
+ Coverage 94.71% 94.73% +0.02%
==========================================
Files 329 329
Lines 48739 48733 -6
==========================================
+ Hits 46161 46166 +5
+ Misses 2578 2567 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
djhoese
reviewed
Feb 20, 2023
Remove the deprecated ability to access dataids by attribute. Now only key access is supported.
gerritholl
changed the title
gerritholl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
__getattr__implementation on DataID, that was implementing a deprecated way to access information from DataID objects. From now on, only key access is possible.