Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DataID attribute access in seviri_l2_grib reader #2408

Merged
merged 3 commits into from
Mar 14, 2023

Conversation

strandgren
Copy link
Collaborator

The recently merged PR #2396, removed the DataID attribute access and modified affected readers accordingly. However, two instances in the seviri_l2_grib reader were not modified leading to failure when using this reader with the current main. This PR resolves this issue.

The initial commit fixed the attribute access, but broke the reader's unit test since a mocked DataID was used, which lead to TypeError since the mock object was not subscriptable. This was resolved by using make_dataid for the test instead.

@djhoese
Copy link
Member

djhoese commented Mar 13, 2023

The initial commit fixed the attribute access, but broke the reader's unit test since a mocked DataID was used, which lead to TypeError since the mock object was not subscriptable. This was resolved by using make_dataid for the test instead.

Over-mocking in tests gets us again.

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is any type of urgency to this PR for your/EUM's work, I'm OK merging it into main if you can confirm that all tests pass locally. We'll deal with the NetCDF test failure in CI in another PR.

@strandgren
Copy link
Collaborator Author

@djhoese I'm missing packages needed to run all the tests, but I can confirm that test_seviri_l2_grib passes locally. But unless we're talking weeks, it's not that urgent.

@mraspaud
Copy link
Member

I just merged #2412 , so the tests should be fixed now if you merge main into this PR

@mraspaud mraspaud added this to the v0.41.0 milestone Mar 14, 2023
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #2408 (11c28a4) into main (673d2e9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2408   +/-   ##
=======================================
  Coverage   94.76%   94.76%           
=======================================
  Files         329      329           
  Lines       48878    48879    +1     
=======================================
+ Hits        46318    46319    +1     
  Misses       2560     2560           
Flag Coverage Δ
behaviourtests 4.42% <0.00%> (-0.01%) ⬇️
unittests 95.39% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/readers/seviri_l2_grib.py 92.47% <100.00%> (ø)
satpy/tests/reader_tests/test_seviri_l2_grib.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mraspaud mraspaud merged commit a2b1d1c into pytroll:main Mar 14, 2023
@coveralls
Copy link

Coverage Status

Coverage: 95.349% (+0.0001%) from 95.349% when pulling 11c28a4 on strandgren:bugfix_seviri_grib_attribute_access into 673d2e9 on pytroll:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants