-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quarkus version to helm #162
Add quarkus version to helm #162
Conversation
@aureamunoz @cmoulliard: This needs a rebase. When it's ready for review please remove the draft flag. |
Ok. It's still in progress... |
ee8788d
to
f67696a
Compare
plugins/quarkus-backend/src/scaffolder/actions/quarkus/createApp.ts
Outdated
Show resolved
Hide resolved
Could you please take a look on that in order to merge it @iocanel ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great and works well too.
I think that we need to apply the change to all of our existing templates (not just the quarkus-application).
Additionally, we need to ensure that the value is quarkus-version label is properly set in the catalog-info.yaml too (currently appears as blank).
locations/templates/quarkus-application/manifests/helm/deploy/templates/_helpers.tpl
Show resolved
Hide resolved
I applied the changes suggested by @iocanel, please review :-) |
Can you fix the conflict please ? @aureamunoz |
baeaa9a
to
967904e
Compare
done |
…helm manifests and catalog. Apply the quarkus version to all of our existing templates and ensure that the quarkus-version label is properly set in the catalog-info.yaml
967904e
to
56fd504
Compare
No description provided.