[SECURITY] Secured Trunk and Glovebox #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converted the the trunk and glovebox items events into functions and exports.
tom-osborne
suggested changes
Nov 12, 2022
Added the bull ---@ and the deprecation messages for the two events
satisfied linter
Further secured the inventory system. I didn't search through the entire core to update teh change so I printed to console to let server ops know that the event, even though it works will be deprecated and to use the export instead.
streamlined the function and still secure.
S33G
reviewed
Nov 19, 2022
Added in the luadoc items
r0adra93
requested review from
tom-osborne and
S33G
and removed request for
tom-osborne
Irishstevie
approved these changes
Nov 23, 2022
There was a problem hiding this comment.
I run this with qb-policejob: qbcore-framework/qb-policejob#422
Tested storage Pull out cars open all the menus
Works good
S33G
reviewed
Nov 23, 2022
S33G
reviewed
Nov 23, 2022
charj won't approve this PR unless I made changes elsewhere in the code. So changes have been made.
r0adra93
requested review from
tom-osborne and
S33G
and removed request for
tom-osborne
commented out the warning. Gotta make some additional security enhancements.
… into r0ad_qb-jobs
Z3rio
changed the title
Z3rio
approved these changes
Dec 14, 2022
|
This PR being merged has created further issues: |
I don't know if it's the act of this PR being merged or the other merges that happened after it. This worked perfectly, then after I pulled an update after this PR it all broke and I said to hell with this and went back to using the unsecure method in qb-jobs. Since the unsecure method was put back into this resource. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted the the trunk and glovebox items events into functions and exports.
Description
Replaced the glovebox and trunk events with functions and exports. Set it up in qb-jobs.
Needs to be merged along with qb-policejob: qbcore-framework/qb-policejob#422
As the trunk script is insecure and it relies on the security update.
Checklist