Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trunk items for policejob #422

Merged
merged 3 commits into from
Feb 25, 2023
Merged

Conversation

GodyFromDiscord
Copy link
Contributor

@GodyFromDiscord GodyFromDiscord commented Feb 22, 2023

Description

At the moment with the latest qb-inventory & qb-policejob install, the trunk items are not added to PD vehicles trunks, this was due to this pull request, this is due to the exports being server sided and being called from a client side script, I have made it so the exported function is still called in Net event, so it can still be used from client side and fixed PD vehicles trunks not having any items added.

This fixes issue #445 for qb-policejob

Checklist

  • I have personally loaded this code into an updated qbcore project and checked all of its functionality.
  • My code fits the style guidelines.
  • My PR fits the contribution guidelines.

server/main.lua Show resolved Hide resolved
@S33G S33G mentioned this pull request Feb 22, 2023
3 tasks
@Z3rio Z3rio added the bug Something isn't working label Feb 22, 2023
@Z3rio Z3rio changed the title inventory: fix adding trunk items for client side/policejob fix: trunk items for policejob Feb 22, 2023
@tom-osborne
Copy link
Contributor

Merge this. Good PR Gody.

Copy link
Contributor

@S33G S33G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@S33G S33G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@S33G S33G merged commit 56b45d1 into qbcore-framework:main Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants