Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open datapackage.zip #304

Closed
Stephen-Gates opened this issue Dec 7, 2017 · 4 comments
Closed

Open datapackage.zip #304

Stephen-Gates opened this issue Dec 7, 2017 · 4 comments
Labels
env:Windows This issue is related to running Data Curator on Windows fn:Open-Data problem:Bug A bug
Milestone

Comments

@Stephen-Gates
Copy link
Contributor

Stephen-Gates commented Dec 7, 2017

Current Behaviour (for problems)

On opening a datapackage.zip file a few issues occur

open-dp

image

  1. an extra data tab is opened
  2. Column widths aren't automatically sized to match data
  3. Import Data Package Success message should be Open Data Package Success to match the menu item name

(sorry to bundle 3 issues into 1)

Your Environment

  • Data Curator version: 0.7.0
  • Operating System and version: Windows 7
@Stephen-Gates Stephen-Gates added env:Windows This issue is related to running Data Curator on Windows fn:Open-Data problem:Bug A bug labels Dec 7, 2017
@Stephen-Gates Stephen-Gates modified the milestones: v0.8.0, v1.x.x Dec 7, 2017
@reminders reminders bot added the reminder label Jan 11, 2018
@Stephen-Gates Stephen-Gates changed the title Open DataPackage.zip Open datapackage.zip Jan 11, 2018
@qcif qcif deleted a comment from reminders bot Jan 11, 2018
@Stephen-Gates
Copy link
Contributor Author

See #411

@ghost
Copy link

ghost commented Mar 12, 2018

@Stephen-Gates

  1. This behaviour is as it should be. The application has no way of knowing whether there is existing data or not in the existing tab. Opening a new tab ensures nothing is accidentally overwritten.
  2. Could you give me a dataset to re-test against. I've opened a QLD Govt dataset, and the columns seem to be resizing correctly
  3. Fixed.

@Stephen-Gates
Copy link
Contributor Author

Stephen-Gates commented Mar 12, 2018

Any of these zip files should work https://github.com/frictionlessdata/example-data-packages/tree/master/zip

Did you see in the screen print when I open duration-test.zip it also opens ._duration-test? Two tabs for the one zip file.

GitHub
example-data-packages - Example Data Packages for use in tutorials

@ghost ghost closed this as completed in b0f4971 Mar 13, 2018
ghost pushed a commit that referenced this issue Mar 13, 2018
@Stephen-Gates
Copy link
Contributor Author

Works fine as far as I can tell 🎉

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
env:Windows This issue is related to running Data Curator on Windows fn:Open-Data problem:Bug A bug
Projects
None yet
Development

No branches or pull requests

1 participant