Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing value per field pattern #608

Conversation

Stephen-Gates
Copy link
Contributor

@Stephen-Gates Stephen-Gates changed the title WIP missing value per field pattern Missing value per field pattern Jun 7, 2019
@rufuspollock
Copy link
Contributor

@Stephen-Gates could this be merged? This looked close to finished ...

@Stephen-Gates
Copy link
Contributor Author

@rufuspollock good to merge

@rufuspollock
Copy link
Contributor

@Stephen-Gates can you rebase this against master as I can't directly merge this atm.

@rufuspollock
Copy link
Contributor

@lauragift21 could you rebase this against master so we can merge?

@lauragift21
Copy link
Contributor

sure @rufuspollock

@lauragift21 lauragift21 force-pushed the missing-values-by-field branch from da1660d to 54430a2 Compare April 30, 2020 20:06
@lauragift21
Copy link
Contributor

@rufuspollock rebase done. I see a lot of changes can you check to see this is what is expected.

@dcslagel
Copy link
Contributor

Hi @rufuspollock , @lauragift21 , @Stephen-Gates ,

I spent some time yesterday to look at why @lauragift21's rebase has more changes than @Stephen-Gates's original change at commit da1660d. I found that the file with the change specs/patterns.md doesn't exist at the current HEAD commit 9706e8c. It looks like specs/patterns.md may have been moved to specs/patterns/README.md. Is that correct?

Thanks,
DC

@rufuspollock
Copy link
Contributor

@dcslagel that's right - this moved to patterns/README.md

@dcslagel
Copy link
Contributor

Thanks @rufuspollock,

Okay, I made a change to get the original content for this pull-request on the current version of `patterns/README.md. It is a separate pull-request #714 . It should enable this content to be merged. See additional notes in #647

DC

@rufuspollock
Copy link
Contributor

FIXED / DUPLICATE. See #714

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants