-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing value per field pattern #608
Missing value per field pattern #608
Conversation
@Stephen-Gates could this be merged? This looked close to finished ... |
@rufuspollock good to merge |
@Stephen-Gates can you rebase this against master as I can't directly merge this atm. |
@lauragift21 could you rebase this against master so we can merge? |
sure @rufuspollock |
da1660d
to
54430a2
Compare
@rufuspollock rebase done. I see a lot of changes can you check to see this is what is expected. |
Hi @rufuspollock , @lauragift21 , @Stephen-Gates , I spent some time yesterday to look at why @lauragift21's rebase has more changes than @Stephen-Gates's original change at commit da1660d. I found that the file with the change Thanks, |
@dcslagel that's right - this moved to |
Thanks @rufuspollock, Okay, I made a change to get the original content for this pull-request on the current version of `patterns/README.md. It is a separate pull-request #714 . It should enable this content to be merged. See additional notes in #647 DC |
FIXED / DUPLICATE. See #714 |
as per https://discuss.okfn.org/t/missing-values-per-field-pattern/6571