Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WasmEdge to 0.14.0 #2125

Merged
merged 11 commits into from
Aug 22, 2024
Merged

Update WasmEdge to 0.14.0 #2125

merged 11 commits into from
Aug 22, 2024

Conversation

Harrm
Copy link
Contributor

@Harrm Harrm commented Jun 13, 2024

Referenced issues

Description of the Change

Possible Drawbacks

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? [Yes|No]
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? [Yes|No]
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? [Yes|No]
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. [Yes|No]

@kamilsa kamilsa requested review from igor-egorov and turuslan and removed request for igor-egorov June 17, 2024 08:41

# hash or version, required later to separate WasmEdge
# binary cache directories from different versions
set(WASMEDGE_ID 58aea400de9179ad3e314c7e84fd4da345b8a643)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get the idea behind dedicating the id to a separate variable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is needed to use this ID in C++ code to add it to the path of the runtime cache. That way when wasmedge version will be updated, a new path to runtime caches will be generated to avoid possible conflicts between incompatible runtimes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And a variable is needed simply because we use this ID in two places in CMakeLists, and if it's not in a variable it will be forgotten in one of them when we change it.

@kamilsa
Copy link
Contributor

kamilsa commented Jul 15, 2024

Merge after #2142

@Harrm Harrm merged commit b0e47a5 into master Aug 22, 2024
11 of 13 checks passed
@Harrm Harrm deleted the update/wasmedge-0.14.0 branch August 22, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants