-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update WasmEdge to 0.14.0 #2125
Conversation
|
||
# hash or version, required later to separate WasmEdge | ||
# binary cache directories from different versions | ||
set(WASMEDGE_ID 58aea400de9179ad3e314c7e84fd4da345b8a643) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get the idea behind dedicating the id to a separate variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is needed to use this ID in C++ code to add it to the path of the runtime cache. That way when wasmedge version will be updated, a new path to runtime caches will be generated to avoid possible conflicts between incompatible runtimes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And a variable is needed simply because we use this ID in two places in CMakeLists, and if it's not in a variable it will be forgotten in one of them when we change it.
Merge after #2142 |
39312b6
to
cdc7b0b
Compare
Referenced issues
Description of the Change
Possible Drawbacks
Checklist Before Opening a PR
Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item: