Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PVF memory reuse #2142

Merged
merged 24 commits into from
Jul 23, 2024
Merged

Remove PVF memory reuse #2142

merged 24 commits into from
Jul 23, 2024

Conversation

Harrm
Copy link
Contributor

@Harrm Harrm commented Jul 1, 2024

Referenced issues

Description of the Change

When PVF validate_block calls reuse wasm module instances, they start breaking. Can be reproduced on 0001 zombietest.

Possible Drawbacks

A bit slower but working PVF execution.

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? Yes
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? [Yes|No]
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? Yes
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. Yes

@Harrm Harrm changed the title Fix/pvf memory reuse Remove PVF memory reuse Jul 9, 2024
@Harrm Harrm marked this pull request as ready for review July 9, 2024 08:20
core/utils/read_file.hpp Outdated Show resolved Hide resolved
core/utils/read_file.hpp Outdated Show resolved Hide resolved
@turuslan turuslan mentioned this pull request Jul 22, 2024
core/parachain/pvf/pool.hpp Outdated Show resolved Hide resolved
core/parachain/pvf/pvf_impl.hpp Outdated Show resolved Hide resolved
core/utils/read_file.hpp Show resolved Hide resolved
core/runtime/common/runtime_instances_pool.cpp Outdated Show resolved Hide resolved
@Harrm Harrm merged commit e8216ce into master Jul 23, 2024
12 of 14 checks passed
@Harrm Harrm deleted the fix/pvf-memory-reuse branch July 23, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants