-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove PVF memory reuse #2142
Merged
Merged
Remove PVF memory reuse #2142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turuslan
reviewed
Jul 2, 2024
Harrm
force-pushed
the
fix/pvf-memory-reuse
branch
from
July 5, 2024 15:56
ac264b3
to
cabbd7d
Compare
turuslan
requested changes
Jul 9, 2024
igor-egorov
approved these changes
Jul 11, 2024
turuslan
reviewed
Jul 11, 2024
turuslan
approved these changes
Jul 12, 2024
Merged
turuslan
requested changes
Jul 22, 2024
turuslan
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Description of the Change
When PVF validate_block calls reuse wasm module instances, they start breaking. Can be reproduced on 0001 zombietest.
Possible Drawbacks
A bit slower but working PVF execution.
Checklist Before Opening a PR
Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item: