Updated Proto files (and generated ones) #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Ich5003. It seems that Travis CI is mostly dead now. Will you be able to send a PR to migrate this repo to GitHub Actions? |
|
Github Actions should work, see .github/workflows/go.yml |
|
@AlekSi Has this PR any chances of getting merged? |
|
@Ich5003 I merged it into a temporary branch to trigger CI. Will do minor tweaks and create a new PR |
AlekSi
reviewed
Apr 30, 2021
| - **New Code**: | ||
|
|
||
| ```protobuf | ||
| option go_package = "OSMPBF"; |
There was a problem hiding this comment.
I added this to Makefile to make .proto files diff smaller:
protoc --go_out=. \
--go_opt=paths=source_relative \
--go_opt=Mfileformat.proto=github.com/qedus/osmpbf/OSMPBF \
--go_opt=Mosmformat.proto=github.com/qedus/osmpbf/OSMPBF \
*.proto
AlekSi
reviewed
Apr 30, 2021
| - **Added Code**: | ||
|
|
||
| ```protobuf | ||
| option optimize_for = LITE_RUNTIME; |
There was a problem hiding this comment.
It does not affect Go code generator: golang/protobuf#788
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this pullrequest updates the following: