Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update proto #37

Merged
merged 17 commits into from
May 10, 2021
Merged

Update proto #37

merged 17 commits into from
May 10, 2021

Conversation

AlekSi
Copy link
Collaborator

@AlekSi AlekSi commented Apr 30, 2021 •
edited
Loading

See comments at #35

@AlekSi AlekSi mentioned this pull request Apr 30, 2021
Merged
@AlekSi
Set Go package name without patch
639cf85 
Signed-off-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
@AlekSi
Tweak README
7f4049e 
Signed-off-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
@AlekSi
Update CI config
eff5ac2 
Signed-off-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
@AlekSi AlekSi force-pushed the update-proto branch 4 times, most recently from e9e09f5 to c6a3a67 Compare April 30, 2021 06:00
@AlekSi AlekSi marked this pull request as ready for review April 30, 2021 06:29
@AlekSi
Copy link
Collaborator Author

AlekSi commented Apr 30, 2021

@Ich5003 PTAL

@AlekSi AlekSi requested a review from jongillham April 30, 2021 06:29
@AlekSi
Add credits
a13c520 
Signed-off-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
@AlekSi
Make error message a bit better
63b88ac 
Signed-off-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
@AlekSi
Remove old references
3a400d0 
Signed-off-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
@haug-den-lucas
Copy link
Contributor

@Ich5003 PTAL

Thank you, looks good to me, if the Build tip test succeeds.

@AlekSi AlekSi mentioned this pull request Apr 30, 2021
Closed
@AlekSi
Copy link
Collaborator Author

AlekSi commented Apr 30, 2021

I believe that's actions-goveralls's bug: shogo82148/actions-goveralls#214

@AlekSi
Set GOROOT explicitly
aac37b3 
Signed-off-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
@AlekSi
Copy link
Collaborator Author

AlekSi commented May 1, 2021

Tests pass now.

@jongillham PTAL

jongillham
jongillham approved these changes May 2, 2021
View reviewed changes
Copy link
Member

@jongillham jongillham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for this. I'm happy for it to be merged.

@AlekSi AlekSi merged commit 3fd1ec1 into master May 10, 2021
@AlekSi AlekSi deleted the update-proto branch May 10, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jongillham jongillham jongillham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @haug-den-lucas @jongillham