Remove reset from beginning of tomography experiments #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some backends do not implement reset but can be treated as having reset the qubits between circuits. It is also possible some backends implement reset but have a slower, higher fidelity reset between circuits than the in-circuit reset.
|
@chriseclectic Do you see a problem with this? It has come up a couple times recently with qiskit-dynamics backends and with experimental backends that are not fully calibrated. |
|
I don't understand the test failures (conditional tomography results slightly under the threshold). The tests are using |
|
I studied the test failures further and decided that there is something funny about AerSimulator when reset is used (see Qiskit/qiskit-aer#1916). As far as I can tell, the results are perfectly reasonable without reset, so the test failures just reflected the tolerances being set too tightly. I ran many seeds and then set the tolerances comfortably larger than the largest deviations I saw (.9409 so set the threshold to .935, and deviations of 1.2e-2 so set the tolerance to 2e-2). |
wshanks
added
the
backport stable potential
mergify bot
pushed a commit
that referenced
this pull request
Aug 25, 2023
### Summary This change removes the reset instruction from the beginning of tomography experiments. ### Details and comments Some backends do not implement reset but can be treated as having reset the qubits between circuits. It is also possible some backends implement reset but have a slower, higher fidelity reset between circuits than the in-circuit reset. (cherry picked from commit 1acc02d)
coruscating
pushed a commit
that referenced
this pull request
Aug 28, 2023
### Summary This change removes the reset instruction from the beginning of tomography experiments. ### Details and comments Some backends do not implement reset but can be treated as having reset the qubits between circuits. It is also possible some backends implement reset but have a slower, higher fidelity reset between circuits than the in-circuit reset. (cherry picked from commit 1acc02d)
coruscating
pushed a commit
that referenced
this pull request
Aug 28, 2023
#1258) This is an automatic backport of pull request #1250 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> Co-authored-by: Will Shanks <willshanks@us.ibm.com>
nkanazawa1989
pushed a commit
to nkanazawa1989/qiskit-experiments
that referenced
this pull request
Jan 10, 2024
…ty#1250) ### Summary This change removes the reset instruction from the beginning of tomography experiments. ### Details and comments Some backends do not implement reset but can be treated as having reset the qubits between circuits. It is also possible some backends implement reset but have a slower, higher fidelity reset between circuits than the in-circuit reset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change removes the reset instruction from the beginning of tomography experiments.
Details and comments
Some backends do not implement reset but can be treated as having reset the qubits between circuits. It is also possible some backends implement reset but have a slower, higher fidelity reset between circuits than the in-circuit reset.