Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reset from beginning of tomography experiments #1250

Merged
merged 3 commits into from
Aug 25, 2023
Merged

Remove reset from beginning of tomography experiments #1250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3601bee
Remove reset from beginning of tomography experiments
wshanks Aug 14, 2023
f6af545
Relax test tolerances
wshanks Aug 24, 2023
a65b4b1
Merge branch 'main' into tomo-reset
wshanks Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion qiskit_experiments/library/tomography/tomography_experiment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,6 @@ def circuits(self):
if prep_element:
# Add tomography preparation
prep_circ = self._prep_circ_basis.circuit(prep_element, self._prep_physical_qubits)
circ.reset(self._prep_indices)
circ.compose(prep_circ, self._prep_indices, inplace=True)
circ.barrier(*self._prep_indices)

Expand Down
8 changes: 8 additions & 0 deletions releasenotes/notes/remove-tomo-reset-3f21ec4d0dacba91.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
other:
- |
Removed the reset instruction from the beginning of tomography experiments.
Since qubits are usually reset between circuits, this change should have no
impact on tomography experiments, but it should allow backends that do not
provide a reset instruction to run tomography experiments. `#1250
<https://github.com/Qiskit-Extensions/qiskit-experiments/issues/881>`
4 changes: 2 additions & 2 deletions test/library/tomography/test_process_tomography.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,7 +568,7 @@ def test_qpt_conditional_circuit(self, circuit_clbits):
fid = qi.process_fidelity(state.value, targets[idx], require_tp=False)
self.assertGreater(
fid,
0.95,
0.935,
msg=f"{fitter} fidelity {fid} is low for conditional outcome {idx}",
)

Expand Down Expand Up @@ -599,7 +599,7 @@ def test_qpt_conditional_meas(self):
prob = state.extra["conditional_probability"]
prob_target = 0.5
self.assertTrue(
np.isclose(prob, prob_target, atol=1e-2),
np.isclose(prob, prob_target, atol=2e-2),
msg=(
f"fitter {fitter} probability incorrect for conditional"
f" measurement {idx} {outcome} ({prob} != {prob_target})"
Expand Down