-
Notifications
You must be signed in to change notification settings - Fork 160
Refactor RB code to use the new Clifford operator class and update the CNOTDihedral class #407
Refactor RB code to use the new Clifford operator class and update the CNOTDihedral class #407
Conversation
I agree with your comment. Indeed, the current CNOTDihedral class has many for loops, and does not use numpy arrays. |
@chriseclectic - thank you very much for the detailed review. I've fixed your latest comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, we can address the Numpy performance issues in a follow up PR
Summary
Refactor RB code to use the new Clifford operator class in Terra quantum_info and the updated CNOTDihedral class:
close #391
close #392
This code allows:
Details and comments
RBgroup
that handles the group methods needed for RBClifford.py
,clifford_utils.py
,dihedral_utils.py
,basic_utils.py
andtest_clifford.py
circuit.py
so that it will useRBgroup
classrb_test.py
to include tests for RB on the Clifford group with more than 2 qubitsAPI updates needed in
randomized_benchmarking_seq
:interleaved_gates
: a list of lists of gates that will be interleaved (Optional[List[List[str]]]),the input will be:
interleaved_elem
: a list of group elements (Cliffords / CNOTDihedral objects).rand_seed
: random number generator seed