This repository has been archived by the owner on Jun 12, 2023. It is now read-only.
Generate json files for RB tests #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dekool I can't merge or update this Pr as its out-of-date with the base branch, and you fix rebase/merge from master to fix this? |
test/rb/generate_data.py
Outdated
|
|
||
| def rb_circuit_execution(rb_opts: dict, shots: int): | ||
| """ | ||
| Create rb circuits with depolarizing error and simulates them |
test/rb/generate_data.py
Outdated
|
|
||
| def rb_circuit_execution_2(rb_opts: dict, shots: int): | ||
| """ | ||
| Create rb circuits with T1 and T2 errors and simulates them |
test/rb/generate_data.py
Outdated
|
|
||
| def rb_interleaved_execution(rb_opts: dict, shots: int): | ||
| """ | ||
| Create interleaved rb circuits with depolarizing error and simulates them |
test/rb/generate_data.py
Outdated
|
|
||
| def rb_cnotdihedral_execution(rb_opts: dict, shots: int): | ||
| """ | ||
| Create cnot-dihedral rb circuits with depolarizing errors and simulates them |
test/rb/generate_data.py
Outdated
|
|
||
| def rb_purity_circuit_execution(rb_opts: dict, shots: int): | ||
| """ | ||
| Create purity rb circuits with depolarizing errors and simulates them |
test/rb/generate_data.py
Outdated
|
|
||
| rb_circs, xdata = rb.randomized_benchmarking_seq(**rb_opts) | ||
|
|
||
| noise_model = NoiseModel() |
There was a problem hiding this comment.
This code (lines 49-50, 54-59) seem to be duplicated in most of the generation functions - maybe it's better to define it in one function and call it once?
| noise_model=noise_model, | ||
| seed_simulator=SEED).result()) | ||
| # coherent purity results | ||
| coherent_results.append(qiskit.execute(current_circ, backend=backend, |
There was a problem hiding this comment.
I don't think that we actually check the coherent error fitter, since it's too noisy, but maybe it's good to keep it as a reference.
chriseclectic
approved these changes
Jul 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added code to generate json files used in the RB fitters tests
Details and comments
Split from #398 in order to separate data generation of different functionalities
the generation of RB json files depends on #407
Hence the code in this PR should be revised after #407 is merged.