Added ability to change length of pin/CPW leading out of transmon cross #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There seem to be some check failing, could you take a look and see if you may be able to resolve them? |
|
|
|
@zlatko-minev just realized I forgot to update the unit test, should be fixed now! |
|
Great work, I assume you tested and it's backwards compatible. Will merge after checks |
zlatko-minev
approved these changes
Jun 14, 2023
| @@ -79,6 +79,8 @@ class TransmonCross(BaseQubit): # pylint: disable=invalid-name | |||
| ground_spacing='5um', | |||
| claw_width='10um', | |||
| claw_gap='6um', | |||
| claw_cpw_length='40um', | |||
There was a problem hiding this comment.
Are these values backwards compatible? Thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the issues this pull addresses (issue numbers / links)?
#946 , #948
Did you add tests to cover your changes (yes/no)?
946: No, not sure if any new tests are needed
948: No, docs change
Did you update the documentation accordingly (yes/no)?
946: Yes
948: No, not applicable
Did you read the CONTRIBUTING document (yes/no)?
Yes
Summary
Added ability to input custom dimensions for the pin attached to the Transmon Cross
Also, fixed issue #948
Details and comments