-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added more options for custom claws in TransmonCross #957
base: main
Are you sure you want to change the base?
Added more options for custom claws in TransmonCross #957
Conversation
Ready for a review? |
Yeah ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me overall, just double check this should be backward-compatible, right?
in other words, people who have made previous designs using this, won’t even notice a difference when loading the updated version. Unless you change one of these options, right
Correct. If the user doesn't input |
It's overall looking good to me, I'll plan to merge |
What are the issues this pull addresses (issue numbers / links)?
Slight corrections & improvements to #949
Did you add tests to cover your changes (yes/no)?
Yes, updated corresponding tests for
TransmonCross
.Did you update the documentation accordingly (yes/no)?
Yes
Did you read the CONTRIBUTING document (yes/no)?
yes
Summary
The standard MIT LL candle qubit has a nonuniform claw thickness. One of the assumptions in the current
TransmonCross
is that you have uniform claw thickness, so this design isn't possible in Qiskit Metal (before this PR!). This update is to give front-end users more control of their claw designs.To illustrate what I mean here's a new potential design you can create.
And yes, it is backward compatible!
Details and comments
TransmonCross
claws.connector_type = 1