Share button state from mousekey to pointing_device #10179

manna-harbour · 2020-08-27T06:55:22Z

Description

If you enable mousekey (mouse keys) with pointing_device (pointing device) and add button keycodes to your keymap, you'll get a click from mousekey but drags with pointing_device movement won't work as button state needs to be sent with the move. If you handle the mousekey button keycodes yourself in process_record_user() to update pointing_device button state you'll break drags using mousekey movement. If you handle mousekey movement keycodes too then you've just re-implemented mousekey.

This change shares button state from mousekey to pointing_device to support simultaneous use of mousekey and pointing_device, including mouse drags with mousekey buttons and mousekey or pointing_device movement.

To use, enable mousekey and pointing_device and add button keycodes to keymap. No extra code is required.

Types of Changes

Core
Enhancement/optimization
Documentation

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

manna-harbour · 2020-08-28T04:12:30Z

The following users have keymaps with pointing_device and button keycodes and might like to try this: @drashna, @vlukash, @alairock, @dr-BEat, @Snipeye.

Update readme.md

manna-harbour · 2020-08-31T00:09:33Z

Rebased after force-pushes to develop.

tzarc

Just a couple of minor consistency changes.

tmk_core/common/action.c

manna-harbour · 2020-09-01T01:15:28Z

Just a couple of minor consistency changes.

Thanks!

Co-authored-by: Nick Brassel <nick@tzarc.org>

manna-harbour · 2020-09-01T01:26:40Z

Squashed.

manna-harbour · 2020-10-05T01:11:47Z

Thanks everyone!

* Branch point for 2020 November 28 Breaking Change Update readme.md * Share button state from mousekey to pointing_device Co-authored-by: Nick Brassel <nick@tzarc.org> Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com> Co-authored-by: Nick Brassel <nick@tzarc.org>

* Branch point for 2020 November 28 Breaking Change * Remove matrix_col_t to allow MATRIX_ROWS > 32 (#10183) * Add support for soft serial to ATmega32U2 (#10204) * Change MIDI velocity implementation to allow direct control of velocity value (#9940) * Add ability to build a subset of all keyboards based on platform. * Actually use eeprom_driver_init(). * Make bootloader_jump weak for ChibiOS. (#10417) * Joystick 16-bit support (#10439) * Per-encoder resolutions (#10259) * Share button state from mousekey to pointing_device (#10179) * Add hotfix for chibios keyboards not wake (#10088) * Add advanced/efficient RGB Matrix Indicators (#8564) * Naming change. * Support for STM32 GPIOF,G,H,I,J,K (#10206) * Add milc as a dependency and remove the installed milc (#10563) * ChibiOS upgrade: early init conversions (#10214) * ChibiOS upgrade: configuration file migrator (#9952) * Haptic and solenoid cleanup (#9700) * XD75 cleanup (#10524) * OLED display update interval support (#10388) * Add definition based on currently-selected serial driver. (#10716) * New feature: Retro Tapping per key (#10622) * Allow for modification of output RGB values when using rgblight/rgb_matrix. (#10638) * Add housekeeping task callbacks so that keyboards/keymaps are capable of executing code for each main loop iteration. (#10530) * Rescale both ChibiOS and AVR backlighting. * Reduce Helix keyboard build variation (#8669) * Minor change to behavior allowing display updates to continue between task ticks (#10750) * Some GPIO manipulations in matrix.c change to atomic. (#10491) * qmk cformat (#10767) * [Keyboard] Update the Speedo firmware for v3.0 (#10657) * Maartenwut/Maarten namechange to evyd13/Evy (#10274) * [quantum] combine repeated lines of code (#10837) * Add step sequencer feature (#9703) * aeboards/ext65 refactor (#10820) * Refactor xelus/dawn60 for Rev2 later (#10584) * add DEBUG_MATRIX_SCAN_RATE_ENABLE to common_features.mk (#10824) * [Core] Added `add_oneshot_mods` & `del_oneshot_mods` (#10549) * update chibios os usb for the otg driver (#8893) * Remove HD44780 References, Part 4 (#10735) * [Keyboard] Add Valor FRL TKL (+refactor) (#10512) * Fix cursor position bug in oled_write_raw functions (#10800) * Fixup version.h writing when using SKIP_VERSION=yes (#10972) * Allow for certain code in the codebase assuming length of string. (#10974) * Add AT90USB support for serial.c (#10706) * Auto shift: support repeats and early registration (#9826) * Rename ledmatrix.h to match .c file (#7949) * Split RGB_MATRIX_ENABLE into _ENABLE and _DRIVER (#10231) * Split LED_MATRIX_ENABLE into _ENABLE and _DRIVER (#10840) * Merge point for 2020 Nov 28 Breaking Change

* Branch point for 2020 November 28 Breaking Change * Remove matrix_col_t to allow MATRIX_ROWS > 32 (qmk#10183) * Add support for soft serial to ATmega32U2 (qmk#10204) * Change MIDI velocity implementation to allow direct control of velocity value (qmk#9940) * Add ability to build a subset of all keyboards based on platform. * Actually use eeprom_driver_init(). * Make bootloader_jump weak for ChibiOS. (qmk#10417) * Joystick 16-bit support (qmk#10439) * Per-encoder resolutions (qmk#10259) * Share button state from mousekey to pointing_device (qmk#10179) * Add hotfix for chibios keyboards not wake (qmk#10088) * Add advanced/efficient RGB Matrix Indicators (qmk#8564) * Naming change. * Support for STM32 GPIOF,G,H,I,J,K (qmk#10206) * Add milc as a dependency and remove the installed milc (qmk#10563) * ChibiOS upgrade: early init conversions (qmk#10214) * ChibiOS upgrade: configuration file migrator (qmk#9952) * Haptic and solenoid cleanup (qmk#9700) * XD75 cleanup (qmk#10524) * OLED display update interval support (qmk#10388) * Add definition based on currently-selected serial driver. (qmk#10716) * New feature: Retro Tapping per key (qmk#10622) * Allow for modification of output RGB values when using rgblight/rgb_matrix. (qmk#10638) * Add housekeeping task callbacks so that keyboards/keymaps are capable of executing code for each main loop iteration. (qmk#10530) * Rescale both ChibiOS and AVR backlighting. * Reduce Helix keyboard build variation (qmk#8669) * Minor change to behavior allowing display updates to continue between task ticks (qmk#10750) * Some GPIO manipulations in matrix.c change to atomic. (qmk#10491) * qmk cformat (qmk#10767) * [Keyboard] Update the Speedo firmware for v3.0 (qmk#10657) * Maartenwut/Maarten namechange to evyd13/Evy (qmk#10274) * [quantum] combine repeated lines of code (qmk#10837) * Add step sequencer feature (qmk#9703) * aeboards/ext65 refactor (qmk#10820) * Refactor xelus/dawn60 for Rev2 later (qmk#10584) * add DEBUG_MATRIX_SCAN_RATE_ENABLE to common_features.mk (qmk#10824) * [Core] Added `add_oneshot_mods` & `del_oneshot_mods` (qmk#10549) * update chibios os usb for the otg driver (qmk#8893) * Remove HD44780 References, Part 4 (qmk#10735) * [Keyboard] Add Valor FRL TKL (+refactor) (qmk#10512) * Fix cursor position bug in oled_write_raw functions (qmk#10800) * Fixup version.h writing when using SKIP_VERSION=yes (qmk#10972) * Allow for certain code in the codebase assuming length of string. (qmk#10974) * Add AT90USB support for serial.c (qmk#10706) * Auto shift: support repeats and early registration (qmk#9826) * Rename ledmatrix.h to match .c file (qmk#7949) * Split RGB_MATRIX_ENABLE into _ENABLE and _DRIVER (qmk#10231) * Split LED_MATRIX_ENABLE into _ENABLE and _DRIVER (qmk#10840) * Merge point for 2020 Nov 28 Breaking Change

* Branch point for 2020 November 28 Breaking Change Update readme.md * Share button state from mousekey to pointing_device Co-authored-by: Nick Brassel <nick@tzarc.org> Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com> Co-authored-by: Nick Brassel <nick@tzarc.org>

noroadsleft force-pushed the develop branch from 9b5e04f to cbcfa54 Compare August 27, 2020 20:35

manna-harbour force-pushed the share-button-state-from-mousekey-to-pointing_device-pr branch from a9a7c90 to dc6654c Compare August 28, 2020 00:06

noroadsleft force-pushed the develop branch from 30fb2d5 to 771bd07 Compare August 28, 2020 17:08

drashna requested a review from a team August 29, 2020 03:23

drashna added core documentation enhancement labels Aug 29, 2020

Branch point for 2020 November 28 Breaking Change

65c27a3

Update readme.md

noroadsleft force-pushed the develop branch from 1d4c0cd to 65c27a3 Compare August 29, 2020 21:41

manna-harbour force-pushed the share-button-state-from-mousekey-to-pointing_device-pr branch from dc6654c to 5af4701 Compare August 31, 2020 00:08

tzarc requested changes Sep 1, 2020

View reviewed changes

tmk_core/common/action.c Outdated Show resolved Hide resolved

tmk_core/common/action.c Outdated Show resolved Hide resolved

tmk_core/common/action.c Outdated Show resolved Hide resolved

tzarc requested a review from a team September 1, 2020 00:54

Share button state from mousekey to pointing_device

b046f4f

Co-authored-by: Nick Brassel <nick@tzarc.org>

manna-harbour force-pushed the share-button-state-from-mousekey-to-pointing_device-pr branch from 2c9c7e9 to b046f4f Compare September 1, 2020 01:25

manna-harbour requested review from tzarc and removed request for a team September 1, 2020 03:30

noroadsleft force-pushed the develop branch from 3a8e1b8 to a1b96ba Compare September 4, 2020 22:03

drashna approved these changes Sep 6, 2020

View reviewed changes

drashna requested a review from a team September 6, 2020 22:24

noroadsleft force-pushed the develop branch from a1b96ba to 3430907 Compare September 12, 2020 11:46

tzarc approved these changes Oct 3, 2020

View reviewed changes

tzarc merged commit f755126 into qmk:develop Oct 3, 2020

manna-harbour deleted the share-button-state-from-mousekey-to-pointing_device-pr branch October 5, 2020 01:11

drashna mentioned this pull request Nov 29, 2020

Improve Pointing Device report sending #11064

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Share button state from mousekey to pointing_device #10179

Share button state from mousekey to pointing_device #10179

manna-harbour commented Aug 27, 2020 •

edited

Loading

manna-harbour commented Aug 28, 2020

manna-harbour commented Aug 31, 2020

tzarc left a comment

manna-harbour commented Sep 1, 2020

manna-harbour commented Sep 1, 2020

manna-harbour commented Oct 5, 2020

Share button state from mousekey to pointing_device #10179

Share button state from mousekey to pointing_device #10179

Conversation

manna-harbour commented Aug 27, 2020 • edited Loading

Description

Types of Changes

Checklist

manna-harbour commented Aug 28, 2020

manna-harbour commented Aug 31, 2020

tzarc left a comment

Choose a reason for hiding this comment

manna-harbour commented Sep 1, 2020

manna-harbour commented Sep 1, 2020

manna-harbour commented Oct 5, 2020

manna-harbour commented Aug 27, 2020 •

edited

Loading