[Keyboard] Add Valor FRL TKL (+refactor) #10512

Xelus22 · 2020-10-02T15:13:17Z

Description

Add Valor FRL TKL.

Types of Changes

Issues Fixed or Closed by This PR

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

zvecr

Due to the changes of valor being refactored to valor/rev1 (both the change in build target, and moving of keymaps folder), this is current considered a "breaking change" and will need to target develop.

keyboards/xelus/valor/frl_tkl/frl_tkl.c

keyboards/xelus/valor/frl_tkl/config.h

Erovia · 2020-10-03T08:59:52Z

Heya! Could you please clean up this PR?
It currently has 151 commits from all over the place and 804 modified files.

I think rebasing your changes to origin/master and force-pushing would be the easiest.
You can reach out to me on Discord if you need help.

zvecr

Cheers for sorting that develop target stuff!

keyboards/xelus/valor/frl_tkl/keymaps/default/config.h

keyboards/xelus/valor/frl_tkl/keymaps/via/config.h

Erovia · 2020-10-04T10:39:53Z

keyboards/xelus/valor/frl_tkl/readme.md

@@ -0,0 +1,13 @@
+# Valor FRL TKL
+


Do you have a pic about the PCB and the board by any chance?

I only have a KLE currenlty.

keyboards/xelus/trinityxttkl/rules.mk

drashna

I think that you don't need the full ChibiOS files. Just what you've changed from default, and #include_next "name", but @tzarc would know best.

Xelus22 · 2020-10-07T23:57:05Z

I dont believe the chibiOS upgrade from tzarc is here yet. Though that is coming soon.

Xelus22 · 2020-10-16T13:51:18Z

I feel like I should change this PR to make this a new keyboard as it is a different layout than the original valor keyboard. I also have plans for revisions of valor (in the same alice layout) and hence should re-factor valor for future revisions in this PR such as the dawn60 revision in #10584 .

Any thoughts?

drashna · 2020-10-18T20:46:42Z

It may be a good idea, yeah, as it may make less work for you later on.

tzarc · 2020-10-31T18:48:02Z

I dont believe the chibiOS upgrade from tzarc is here yet. Though that is coming soon.

Doesn't need to be here -- the ChibiOS upgrade isn't tightly coupled to config migrations.

That said, no need to concern yourself with making the mods -- I'll just add this board to the conversion list while I prep all the changes across the repo.

Co-authored-by: Joel Challis <git@zvecr.com>

* Branch point for 2020 November 28 Breaking Change * Remove matrix_col_t to allow MATRIX_ROWS > 32 (#10183) * Add support for soft serial to ATmega32U2 (#10204) * Change MIDI velocity implementation to allow direct control of velocity value (#9940) * Add ability to build a subset of all keyboards based on platform. * Actually use eeprom_driver_init(). * Make bootloader_jump weak for ChibiOS. (#10417) * Joystick 16-bit support (#10439) * Per-encoder resolutions (#10259) * Share button state from mousekey to pointing_device (#10179) * Add hotfix for chibios keyboards not wake (#10088) * Add advanced/efficient RGB Matrix Indicators (#8564) * Naming change. * Support for STM32 GPIOF,G,H,I,J,K (#10206) * Add milc as a dependency and remove the installed milc (#10563) * ChibiOS upgrade: early init conversions (#10214) * ChibiOS upgrade: configuration file migrator (#9952) * Haptic and solenoid cleanup (#9700) * XD75 cleanup (#10524) * OLED display update interval support (#10388) * Add definition based on currently-selected serial driver. (#10716) * New feature: Retro Tapping per key (#10622) * Allow for modification of output RGB values when using rgblight/rgb_matrix. (#10638) * Add housekeeping task callbacks so that keyboards/keymaps are capable of executing code for each main loop iteration. (#10530) * Rescale both ChibiOS and AVR backlighting. * Reduce Helix keyboard build variation (#8669) * Minor change to behavior allowing display updates to continue between task ticks (#10750) * Some GPIO manipulations in matrix.c change to atomic. (#10491) * qmk cformat (#10767) * [Keyboard] Update the Speedo firmware for v3.0 (#10657) * Maartenwut/Maarten namechange to evyd13/Evy (#10274) * [quantum] combine repeated lines of code (#10837) * Add step sequencer feature (#9703) * aeboards/ext65 refactor (#10820) * Refactor xelus/dawn60 for Rev2 later (#10584) * add DEBUG_MATRIX_SCAN_RATE_ENABLE to common_features.mk (#10824) * [Core] Added `add_oneshot_mods` & `del_oneshot_mods` (#10549) * update chibios os usb for the otg driver (#8893) * Remove HD44780 References, Part 4 (#10735) * [Keyboard] Add Valor FRL TKL (+refactor) (#10512) * Fix cursor position bug in oled_write_raw functions (#10800) * Fixup version.h writing when using SKIP_VERSION=yes (#10972) * Allow for certain code in the codebase assuming length of string. (#10974) * Add AT90USB support for serial.c (#10706) * Auto shift: support repeats and early registration (#9826) * Rename ledmatrix.h to match .c file (#7949) * Split RGB_MATRIX_ENABLE into _ENABLE and _DRIVER (#10231) * Split LED_MATRIX_ENABLE into _ENABLE and _DRIVER (#10840) * Merge point for 2020 Nov 28 Breaking Change

* Branch point for 2020 November 28 Breaking Change * Remove matrix_col_t to allow MATRIX_ROWS > 32 (qmk#10183) * Add support for soft serial to ATmega32U2 (qmk#10204) * Change MIDI velocity implementation to allow direct control of velocity value (qmk#9940) * Add ability to build a subset of all keyboards based on platform. * Actually use eeprom_driver_init(). * Make bootloader_jump weak for ChibiOS. (qmk#10417) * Joystick 16-bit support (qmk#10439) * Per-encoder resolutions (qmk#10259) * Share button state from mousekey to pointing_device (qmk#10179) * Add hotfix for chibios keyboards not wake (qmk#10088) * Add advanced/efficient RGB Matrix Indicators (qmk#8564) * Naming change. * Support for STM32 GPIOF,G,H,I,J,K (qmk#10206) * Add milc as a dependency and remove the installed milc (qmk#10563) * ChibiOS upgrade: early init conversions (qmk#10214) * ChibiOS upgrade: configuration file migrator (qmk#9952) * Haptic and solenoid cleanup (qmk#9700) * XD75 cleanup (qmk#10524) * OLED display update interval support (qmk#10388) * Add definition based on currently-selected serial driver. (qmk#10716) * New feature: Retro Tapping per key (qmk#10622) * Allow for modification of output RGB values when using rgblight/rgb_matrix. (qmk#10638) * Add housekeeping task callbacks so that keyboards/keymaps are capable of executing code for each main loop iteration. (qmk#10530) * Rescale both ChibiOS and AVR backlighting. * Reduce Helix keyboard build variation (qmk#8669) * Minor change to behavior allowing display updates to continue between task ticks (qmk#10750) * Some GPIO manipulations in matrix.c change to atomic. (qmk#10491) * qmk cformat (qmk#10767) * [Keyboard] Update the Speedo firmware for v3.0 (qmk#10657) * Maartenwut/Maarten namechange to evyd13/Evy (qmk#10274) * [quantum] combine repeated lines of code (qmk#10837) * Add step sequencer feature (qmk#9703) * aeboards/ext65 refactor (qmk#10820) * Refactor xelus/dawn60 for Rev2 later (qmk#10584) * add DEBUG_MATRIX_SCAN_RATE_ENABLE to common_features.mk (qmk#10824) * [Core] Added `add_oneshot_mods` & `del_oneshot_mods` (qmk#10549) * update chibios os usb for the otg driver (qmk#8893) * Remove HD44780 References, Part 4 (qmk#10735) * [Keyboard] Add Valor FRL TKL (+refactor) (qmk#10512) * Fix cursor position bug in oled_write_raw functions (qmk#10800) * Fixup version.h writing when using SKIP_VERSION=yes (qmk#10972) * Allow for certain code in the codebase assuming length of string. (qmk#10974) * Add AT90USB support for serial.c (qmk#10706) * Auto shift: support repeats and early registration (qmk#9826) * Rename ledmatrix.h to match .c file (qmk#7949) * Split RGB_MATRIX_ENABLE into _ENABLE and _DRIVER (qmk#10231) * Split LED_MATRIX_ENABLE into _ENABLE and _DRIVER (qmk#10840) * Merge point for 2020 Nov 28 Breaking Change

zvecr requested changes Oct 2, 2020

View reviewed changes

keyboards/xelus/valor/frl_tkl/frl_tkl.c Outdated Show resolved Hide resolved

keyboards/xelus/valor/frl_tkl/config.h Outdated Show resolved Hide resolved

zvecr added breaking_change Changes that need to wait for a version increment keyboard via Adds via keymap and/or updates keyboard for via support labels Oct 2, 2020

zvecr requested a review from a team October 2, 2020 20:07

Xelus22 changed the base branch from master to develop October 3, 2020 05:00

Xelus22 force-pushed the valor_frl_tkl branch 5 times, most recently from def525a to 86e48fe Compare October 3, 2020 12:29

Xelus22 changed the base branch from develop to master October 3, 2020 12:30

Xelus22 changed the base branch from master to develop October 3, 2020 12:30

Xelus22 force-pushed the valor_frl_tkl branch 2 times, most recently from 1a87211 to 7c2f502 Compare October 3, 2020 12:53

zvecr requested changes Oct 3, 2020

View reviewed changes

keyboards/xelus/valor/frl_tkl/keymaps/default/config.h Outdated Show resolved Hide resolved

keyboards/xelus/valor/frl_tkl/keymaps/via/config.h Outdated Show resolved Hide resolved

Erovia reviewed Oct 4, 2020

View reviewed changes

drashna reviewed Oct 7, 2020

View reviewed changes

github-actions bot added the keymap label Oct 18, 2020

skullydazed force-pushed the develop branch from fa8cf59 to cce70f1 Compare October 18, 2020 21:10

noroadsleft force-pushed the develop branch from 5720202 to dcefc1a Compare October 23, 2020 22:37

skullydazed force-pushed the develop branch from db745a9 to 68fc044 Compare October 28, 2020 02:16

noroadsleft force-pushed the develop branch from 92ca6b9 to c3221d4 Compare October 30, 2020 20:23

github-actions bot added the core label Nov 1, 2020

frl tkl

fae2b5b

Xelus22 and others added 8 commits November 1, 2020 13:05

refator

df8be69

removebootloaderfile

cfe54ca

zvecr recommended changes

a87f940

fix default keymap

f9d648a

Update keyboards/xelus/valor/frl_tkl/keymaps/default/config.h

6e7253a

Co-authored-by: Joel Challis <git@zvecr.com>

Update keyboards/xelus/valor/frl_tkl/keymaps/via/config.h

e25825b

Co-authored-by: Joel Challis <git@zvecr.com>

remove accidental

1f02d47

move frl tkl to its own keyboard

55dc557

Xelus22 force-pushed the valor_frl_tkl branch from 7a50960 to 55dc557 Compare November 1, 2020 02:05

github-actions bot removed the core label Nov 1, 2020

fixup readme

88dc838

drashna approved these changes Nov 1, 2020

View reviewed changes

drashna requested a review from a team November 1, 2020 18:07

fauxpark approved these changes Nov 1, 2020

View reviewed changes

drashna merged commit 0bfec7b into qmk:develop Nov 15, 2020

Xelus22 deleted the valor_frl_tkl branch March 24, 2021 10:42

Xelus22 mentioned this pull request Jul 16, 2021

Add Valor FRL TKL the-via/keyboards#811

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Keyboard] Add Valor FRL TKL (+refactor) #10512

[Keyboard] Add Valor FRL TKL (+refactor) #10512

Xelus22 commented Oct 2, 2020

zvecr left a comment

Erovia commented Oct 3, 2020

zvecr left a comment

Erovia Oct 4, 2020

Xelus22 Oct 5, 2020

drashna left a comment

Xelus22 commented Oct 7, 2020

Xelus22 commented Oct 16, 2020 •

edited

Loading

drashna commented Oct 18, 2020

tzarc commented Oct 31, 2020

[Keyboard] Add Valor FRL TKL (+refactor) #10512

[Keyboard] Add Valor FRL TKL (+refactor) #10512

Conversation

Xelus22 commented Oct 2, 2020

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

zvecr left a comment

Choose a reason for hiding this comment

Erovia commented Oct 3, 2020

zvecr left a comment

Choose a reason for hiding this comment

Erovia Oct 4, 2020

Choose a reason for hiding this comment

Xelus22 Oct 5, 2020

Choose a reason for hiding this comment

drashna left a comment

Choose a reason for hiding this comment

Xelus22 commented Oct 7, 2020

Xelus22 commented Oct 16, 2020 • edited Loading

drashna commented Oct 18, 2020

tzarc commented Oct 31, 2020

Xelus22 commented Oct 16, 2020 •

edited

Loading