Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Lucid to Maker Keyboards to reflect current branding #14284

Closed
wants to merge 5 commits into from
Closed

Change Lucid to Maker Keyboards to reflect current branding #14284

wants to merge 5 commits into from

Conversation

mrnoisytiger
Copy link
Contributor

Description

Maker Keyboard was known as LucidKB during prelaunch. However, it's name changed officially to Maker Keyboards following the launch/release. This change modifies all source files as well as the source folder to reflect the name change.

No other changes.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added dependencies keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Sep 3, 2021
@tzarc tzarc changed the base branch from master to develop September 3, 2021 05:13
@zvecr
Copy link
Member

zvecr commented Sep 4, 2021

In its current form, this PR cannot be accepted due to the submodule changes in lib, most likely from before the previous develop cycle merged. These will need to be resolved before the PR can move forward.

@github-actions github-actions bot added cli qmk cli command python and removed dependencies labels Sep 4, 2021
@mrnoisytiger
Copy link
Contributor Author

closing because i made it worse. Will reapply changes in new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli qmk cli command keyboard keymap python via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants