Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Lucid to Maker Keyboards to reflect current branding (Fixed) #14307

Closed
wants to merge 2 commits into from
Closed

Change Lucid to Maker Keyboards to reflect current branding (Fixed) #14307

wants to merge 2 commits into from

Conversation

mrnoisytiger
Copy link
Contributor

Description

Maker Keyboard was known as LucidKB during prelaunch. However, it's name changed officially to Maker Keyboards following the launch/release. This change modifies all source files as well as the source folder to reflect the name change.

No other changes.

@zvecr New Pull Request for #14284 which should fix the lib issues.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Sep 4, 2021
@mrnoisytiger mrnoisytiger changed the title Lucid to maker 2 Change Lucid to Maker Keyboards to reflect current branding (Fixed) Sep 4, 2021
@drashna
Copy link
Member

drashna commented Sep 8, 2021

Since this is moving the location of the boards, this would need to target develop

@tzarc tzarc changed the base branch from master to develop September 8, 2021 03:45
@stale
Copy link

stale bot commented Oct 24, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@mrnoisytiger
Copy link
Contributor Author

mrnoisytiger commented Oct 25, 2021

Please no stale. 😭 @drashna

@drashna
Copy link
Member

drashna commented Oct 26, 2021

There are a bunch of merge conflicts here that need to be resolved.

@noroadsleft
Copy link
Member

This pull request needs to be rebased; the following files have been updated on our side since you submitted them.

  • keyboards/lucid/kbd8x_hs/info.json
  • keyboards/lucid/phantom_hs/info.json
  • keyboards/lucid/phantom_solder/info.json
  • keyboards/lucid/scarlet/info.json

For context, see PRs #14274 and #14799

@stale
Copy link

stale bot commented Apr 16, 2022

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting changes keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants